From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36219: GNU Emacs 26.1 --eval rejects trailing whitespace Date: Sat, 15 Jun 2019 10:06:22 -0400 Message-ID: <87d0jfymch.fsf@gmail.com> References: <87ftobynvt.fsf@gmail.com> <834l4rvtqr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="230692"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: andpuke@foxmail.com, 36219@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 15 16:07:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hc9Kn-000xnu-JA for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 16:07:09 +0200 Original-Received: from localhost ([::1]:60754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc9Km-0007Eo-EL for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 10:07:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53425) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc9Kh-0007Eg-HG for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc9Kg-0008D0-IT for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53734) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hc9Kg-0008Cp-DT for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hc9Kg-000103-5g for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 10:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jun 2019 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36219-submit@debbugs.gnu.org id=B36219.15606075943807 (code B ref 36219); Sat, 15 Jun 2019 14:07:02 +0000 Original-Received: (at 36219) by debbugs.gnu.org; 15 Jun 2019 14:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:39045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hc9KB-0000zG-70 for submit@debbugs.gnu.org; Sat, 15 Jun 2019 10:06:33 -0400 Original-Received: from mail-io1-f54.google.com ([209.85.166.54]:39273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hc9K9-0000z3-BH for 36219@debbugs.gnu.org; Sat, 15 Jun 2019 10:06:29 -0400 Original-Received: by mail-io1-f54.google.com with SMTP id r185so6044884iod.6 for <36219@debbugs.gnu.org>; Sat, 15 Jun 2019 07:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cRcu8Y0eCX/YFNIvleAKO94kDb5KDyKpTOeXam5pgD8=; b=VvwiHwzTNp1hKUbWYHTkgz4Y33PwAsxPgWzNxDPLLNXy5UOQ/uz6Yuc/VZTLrs7H5D Siyeh7GCNhm9dh9zoDSkvLXVFxIq+BGfF2wE2Y57fWrlCiUxp3lL9vwO2jq/WZNt4o8L XQUlMxpj/6bY4wmP3GLhBv5iZiaVInlDRDr67TsstGRJMJSZssEceXXpiD8QeRP69jXZ lMTv31tR3+2N97DkV9AXGbPUWdlFHOdhMe50z80tETIM6eXVsRrpDzQGuhaifg6H9OG9 pGvUo5FvWRbsfSSOAqKFsYQhPK0XRp2herAiquB++L+PvGdqFdLGON0Ue/1ynuau/10h GQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cRcu8Y0eCX/YFNIvleAKO94kDb5KDyKpTOeXam5pgD8=; b=PddFLTnXIOnUsNro3JJv4oWKEEMOqIzhJEdkjPzEUDhmC7W5Szu76JYEJUQn3oSfQh +acLH2ikpY+xCVE9upUFyDFPtPr66rJgGufb/8YPexr/Ra9B010/CTpEVPntuoIZrURt /TVYAru1LIu6xb9Cw6Qmr6Et2M8ssVGkmoLYoHYJFc0hfO7HnNumrY8WKBkn1hXfZPsx kRex2KTSdqw3Bk+c+A8u2a0zte5Fmmlm+ji183ZA1HIQOJ20ew/VK9yhZMh9AOA7l3k9 hNQZ1haM43kzg71OfMtHZszaoUwFRtK232L5r9WCNCPAtb4uVVHwGiH86UXZgWkobrEI TSdw== X-Gm-Message-State: APjAAAVvqd0+h6oZqHgOpbmXCzhkYo0WR3nQzMVQ6pLVAgIxP/s0NdeY EUYkaeLfalTt8qUBtziR7ptoVToe X-Google-Smtp-Source: APXvYqxXK797UCKnQM6N/pjn22s9gN8VGjDzOeq6y1jYw397KTvEooXhuT/IbYeCvcoc3fGrx/+zlg== X-Received: by 2002:a6b:e61a:: with SMTP id g26mr14080783ioh.300.1560607583463; Sat, 15 Jun 2019 07:06:23 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id e84sm10893524iof.39.2019.06.15.07.06.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Jun 2019 07:06:23 -0700 (PDT) In-Reply-To: <834l4rvtqr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jun 2019 16:54:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160614 Archived-At: Eli Zaretskii writes: >> I think I'd prefer checking the trailing garbage for whitespace, which >> is what eval-expression does. See following patch: > > SGTM, thanks. Not sure if you missed my question about emacs-26 (it was below the patch, maybe a bad place to put it) This is a regression from Emacs 25, and the fix looks pretty safe to me; although the bug isn't especially severe. Should it go to emacs-26?