From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36897: 27.0.50; [CC Mode] c-after-change may signal error in narrowed buffer Date: Thu, 01 Aug 2019 20:30:17 -0400 Message-ID: <87d0hotnmu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103696"; mail-complaints-to="usenet@blaine.gmane.org" To: 36897@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 02 02:31:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htLTX-000Qop-Ob for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 02:31:15 +0200 Original-Received: from localhost ([::1]:59926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htLTW-0002GG-NN for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Aug 2019 20:31:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41219) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htLTR-0002Fy-Co for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 20:31:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htLTP-0006nF-Qm for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 20:31:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46822) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htLTJ-0006iH-Uk; Thu, 01 Aug 2019 20:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htLTJ-0003qE-PG; Thu, 01 Aug 2019 20:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 02 Aug 2019 00:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36897 X-GNU-PR-Package: emacs, cc-mode X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156470582714721 (code B ref -1); Fri, 02 Aug 2019 00:31:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Aug 2019 00:30:27 +0000 Original-Received: from localhost ([127.0.0.1]:55643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htLSk-0003pN-Cf for submit@debbugs.gnu.org; Thu, 01 Aug 2019 20:30:26 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htLSh-0003pF-Qv for submit@debbugs.gnu.org; Thu, 01 Aug 2019 20:30:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40389) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htLSg-00028f-JW for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 20:30:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htLSf-0005pJ-9K for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 20:30:22 -0400 Original-Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:45379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htLSf-0005o2-27 for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2019 20:30:21 -0400 Original-Received: by mail-io1-xd35.google.com with SMTP id g20so148435611ioc.12 for ; Thu, 01 Aug 2019 17:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=KJ4fvFEAD8u8vFf7qW9yDlbF7UxHPZCWD1bbSaq7Syo=; b=Yss/79i2BA3nkzEs3KZ13/hoFW+zY/2LdW0Py2kFtlP0DeIv7eA+ZXpzoGJf0gkmPB 74PQ0DDbJZrgXuwwIwQY2rPJigAaUDW/4iRZBcL5P4oLdBHepp/eM51CsvcIDryilnqD GN1IOipfrR1u0yCqw+TUnlWXONiciOZ96+3+h6Bru7EjIQL+qJPPavCiDSw+aVJ9Qg26 7HqSi5DyjYjB6fHrnyKAIKHSgluN+05/0GbFqf/S+fDU8YY7I92vX73+ugMVwwKekucm +FH/4gnRfWD3bvMYTtRVpchSUdSSm1WrDwQi+Y9YBHO6xEVv9Dgiiqu+FpuWDHUZftY0 BSgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=KJ4fvFEAD8u8vFf7qW9yDlbF7UxHPZCWD1bbSaq7Syo=; b=f35fcRJB0d2nwXvTx3Jk75B1IyDWyalrzJk3slZmrt1y6eKzBIeej4MUmbjy/KRuLm 2r+GkMZa2VWm4TTI+PNkp4Y9l9rjbWtXkUgcpgdeYJTIR5LcwAXs8Pwyyt/TgpfLMchZ /v9WdX/Y07ZL8JmDrIchKns9V1R1r0QHU9TPJPETz55L0GVlgPaRssulmDrZUGSVr9ul yFNdH/NqNgwy5fil3xKpr8DfYu6ZQn8c8IKjIydoiLF02zfwFiXZkpG+D09LzM1aPukZ ZnQGBr9E8wpjK90pF0fUWXgvvSGPSFZ8w01xOx8qcSEg5cTeSr8QRe6nX4hgrE2SFJny 4N0g== X-Gm-Message-State: APjAAAXzcsIygDnFtHWvrGVxT40+naFoj4bhtgkjnor4aLN3A2BnTyP5 1Tpd7FvHWEptYY3D3RFgg/GmrN00 X-Google-Smtp-Source: APXvYqz9AVCcACxXuCT2ElENrXPFkG5ORflGY/962KPutN0xRQVBXtbKjIoJ7jDNH2s3tZh22hha8w== X-Received: by 2002:a02:c65a:: with SMTP id k26mr1115400jan.18.1564705820117; Thu, 01 Aug 2019 17:30:20 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id j1sm65471466iop.14.2019.08.01.17.30.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Aug 2019 17:30:18 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164293 Archived-At: --=-=-= Content-Type: text/plain Package: emacs, cc-mode >From 'emacs -Q', eval the following: (with-current-buffer (get-buffer-create "*test*") (erase-buffer) (insert "int main()\n{\n \n}\n") (search-backward "\n}") (c-mode) (save-restriction (narrow-to-region (point) (point)) (insert "foo"))) Gives the backtrace: Debugger entered--Lisp error: (args-out-of-range 1 1) get-text-property(1 c-fl-syn-tab) c-clear-string-fences() #f(compiled-function () #)() c-after-change(16 19 0) insert("foo") (save-restriction (narrow-to-region (point) (point)) (insert "foo")) (save-current-buffer (set-buffer (get-buffer-create "*test*")) (erase-buffer) (insert "int main()\n{\n \n}\n") (search-backward "\n}") (c-mode) (save-restriction (narrow-to-region (point) (point)) (insert "foo"))) This is a reduced test case from https://github.com/joaotavora/eglot/issues/291. I think the obvious fix is to extend the save-restriction just a bit further to cover c-clear-string-fences, patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-c-after-change-in-narrowed-buffer.patch Content-Description: patch >From 2865541594f18898c234a2ed076879ce2f887693 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 1 Aug 2019 20:14:32 -0400 Subject: [PATCH] Fix c-after-change in narrowed buffer * lisp/progmodes/cc-mode.el (c-after-change): Include the c-clear-string-fences call in the save-restriction, so that it has access to the widened buffer. --- lisp/progmodes/cc-mode.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el index a5e158933b..9df4224448 100644 --- a/lisp/progmodes/cc-mode.el +++ b/lisp/progmodes/cc-mode.el @@ -1989,10 +1989,10 @@ c-after-change ;; When `combine-after-change-calls' is used we might get calls ;; with regions outside the current narrowing. This has been ;; observed in Emacs 20.7. - (unwind-protect - (progn - (c-restore-string-fences (point-min) (point-max)) - (save-restriction + (save-restriction + (unwind-protect + (progn + (c-restore-string-fences (point-min) (point-max)) (save-match-data ; c-recognize-<>-arglists changes match-data (widen) @@ -2032,8 +2032,8 @@ c-after-change (save-excursion (mapc (lambda (fn) (funcall fn beg end old-len)) - c-before-font-lock-functions))))) - (c-clear-string-fences)))) + c-before-font-lock-functions)))) + (c-clear-string-fences))))) ;; A workaround for syntax-ppss's failure to notice syntax-table text ;; property changes. (when (fboundp 'syntax-ppss) -- 2.11.0 --=-=-= Content-Type: text/plain In GNU Emacs 27.0.50 (build 23, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2019-07-30 built on minid Repository revision: 3a59cc84069376802ba8fd731b524d78db58262c Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9 (stretch) Recent messages: Error during redisplay: (jit-lock-function 18) signaled (args-out-of-range 1 1) Continuing. c-clear-string-fences: Args out of range: 1, 1 --=-=-=--