From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Date: Sun, 04 Aug 2019 14:45:26 +0200 Message-ID: <87d0hl3xqx.fsf@web.de> References: <400906ac-35f1-48e4-8df9-8e65b340209b@default> <87vbrjdajs.fsf@web.de> <82178260-247b-4653-85db-d6586480419e@default> <87d2dqdsyj.fsf@web.de> <8736ihb0ds.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177170"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , 17871@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 15:11:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huGI1-000jy9-U3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 15:11:10 +0200 Original-Received: from localhost ([::1]:44438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGI0-0002Ub-P9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 09:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47512) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGHv-0002UT-Lc for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huGHu-0005KI-LO for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huGHu-0005KC-Ev for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huGHu-0000AG-9E for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17871 X-GNU-PR-Package: emacs Original-Received: via spool by 17871-submit@debbugs.gnu.org id=B17871.1564924253603 (code B ref 17871); Sun, 04 Aug 2019 13:11:02 +0000 Original-Received: (at 17871) by debbugs.gnu.org; 4 Aug 2019 13:10:53 +0000 Original-Received: from localhost ([127.0.0.1]:60773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGHk-00009e-MW for submit@debbugs.gnu.org; Sun, 04 Aug 2019 09:10:52 -0400 Original-Received: from mout.web.de ([217.72.192.78]:43607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGHh-000098-H1 for 17871@debbugs.gnu.org; Sun, 04 Aug 2019 09:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1564924241; bh=cUe2QU5j7BXPRuBXbji1fCUYF+hiS33uDmjXppvLgcY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Sp1+2cOyYXJ6B6esI+jqSPt+sqwj1E/ssEDdCo2ZsUIqMNDos44Q5C98P68H4EwTJ RGMixqC4/slTISXHUAweb0OXhUNzbMKaIDQRic2Wa+43q+jsCNydVe21PtgjNq6kiO BTG2BNQrOq2Su6+CexDrGJ94UHWTQVQlcV7wnrOc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([92.208.178.242]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MGign-1i7kHQ3JSr-00DZzW; Sun, 04 Aug 2019 14:45:29 +0200 In-Reply-To: <8736ihb0ds.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sun, 04 Aug 2019 14:06:39 +0200") X-Provags-ID: V03:K1:NV29cO5x11WF9NmROy9JY0K+jK9prCPgXONeFGtn/ERguy1aE5+ uUjrk+KX9quedgS7u1L76UoTskzLaJoXmiJ5uTx8OsLg7jMhCU38BfslZEK6kAMjYG2/MkH ksl6V1mp1gaCmvJkaBfo4AA+AOIGD0aPt9FjCOzQ7TJ1Khq/z4ZnOFfSEPLWMhzdPUCTRV9 fmfLFlfMThBcJ8gy+p+Fg== X-UI-Out-Filterresults: notjunk:1;V03:K0:iLiQYuc/Zf0=:T4uKdk7AyDKYHSJjdQ/FUM 4if6MRICZsr8pEOxjYyjTk7/AaUAsHCOfqhyrnGepv+1K0ygv/BmQEF8v25glNhIH4bpr6g4m OidPzLtA0NB0uOykCSBeJmwg2jkQJWG7mNH/D2O43ujlm76mr1NiqzJvnx2ue+9EInl5Hs/nM J26XCQepUyuEH/FYlcIRK+1UEV0tzORkiu+OM+SQt0sEpBFvH8vndYuAYCGebf7gOLXjE1jvX nL/QMaLnnLTR8zmbkzcqHUeqxYfXuoGBtqeSVrpqLyE6BePaB7O0odUOg4Wx0ZYF6VsDOa6rU HhyKU5k5GZ7XbYBSon+K/tYysD8b+MyLHUFILVpJ57gO8B3syZyjd76YF4F2PHEMGlCOMEFUc Ds+G06L9H6R2uVrSO4GlFHC4l0lcpbtEPazY251CCRf6vbQin+/RyONAXdt7Ko5hoBSAyVWMf r+jzHZCw6mBX+OmDcBuy4tltXIkHfh2cqBZFSWfOAUgfhwzyuxV/NanegwrIMkbwfOI39nRRk dvnqgmCaRYqPyqbgsnPtMYilMm+3ADkzUWTdrEVr5+2D6iqqhYjEKwDakwE7Qw5n1zuXQhu3j d5sKeSXKovwH5GvzXKU/5OR9Q4braYIoL4e0RyS1sPhq+CyIhG9dNbO+tGuiA2VE4pKsAiVus /x+z7Y5UFXuRHHrRow2Q5HxxwOykNo3huYk3Ko5cPFVG6cwxjjYcDWhT8RGTzm/0rPSMWOICE 7LfGe20N7eksk1yzBqtN3TBNDxKt8+jk0+0qSejtTyveu17gK1v3MG5A3shSGd9BnpuIDZbK X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164563 Archived-At: Lars Ingebrigtsen writes: > (defun advice-eval-interactive-spec (spec) > "Evaluate the interactive spec SPEC." > (cond > ((stringp spec) > ;; There's no direct access to the C code (in call-interactively) th= at > ;; processes those specs, but that shouldn't stop us, should it? > ;; FIXME: Despite appearances, this is not faithful: SPEC and > ;; (advice-eval-interactive-spec SPEC) will behave subtly differentl= y w.r.t > ;; command-history (and maybe a few other details). > (call-interactively `(lambda (&rest args) (interactive ,spec) args))= ) > ;; ((functionp spec) (funcall spec)) > (t (eval spec)))) > > The functionp case is commented out? This was apparently done in > 1668ea9062e (in 2012!) by Stefan while rewriting this stuff. > > If nobody has missed this since 2012... perhaps it should just be > removed? I guess SPEC is never functionp, at least after that change. By skimming over the code, the (interactive (lambda (old-interactive-form) ...)) case is transformed by `advice--make-interactive-form' to something else that is not a function, and apart from this, interactive specs are never functionp. Michael.