From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 17871@debbugs.gnu.org
Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function?
Date: Sun, 04 Aug 2019 14:45:26 +0200 [thread overview]
Message-ID: <87d0hl3xqx.fsf@web.de> (raw)
In-Reply-To: <8736ihb0ds.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sun, 04 Aug 2019 14:06:39 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> (defun advice-eval-interactive-spec (spec)
> "Evaluate the interactive spec SPEC."
> (cond
> ((stringp spec)
> ;; There's no direct access to the C code (in call-interactively) that
> ;; processes those specs, but that shouldn't stop us, should it?
> ;; FIXME: Despite appearances, this is not faithful: SPEC and
> ;; (advice-eval-interactive-spec SPEC) will behave subtly differently w.r.t
> ;; command-history (and maybe a few other details).
> (call-interactively `(lambda (&rest args) (interactive ,spec) args)))
> ;; ((functionp spec) (funcall spec))
> (t (eval spec))))
>
> The functionp case is commented out? This was apparently done in
> 1668ea9062e (in 2012!) by Stefan while rewriting this stuff.
>
> If nobody has missed this since 2012... perhaps it should just be
> removed?
I guess SPEC is never functionp, at least after that change. By
skimming over the code, the
(interactive (lambda (old-interactive-form) ...))
case is transformed by `advice--make-interactive-form' to something else
that is not a function, and apart from this, interactive specs are never
functionp.
Michael.
next prev parent reply other threads:[~2019-08-04 12:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 14:13 bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Drew Adams
2014-06-29 15:01 ` Michael Heerdegen
2014-06-29 15:52 ` Drew Adams
2014-06-29 22:03 ` Stefan Monnier
2014-06-29 23:49 ` Drew Adams
2014-06-30 20:48 ` Michael Heerdegen
2019-08-04 12:06 ` Lars Ingebrigtsen
2019-08-04 12:45 ` Michael Heerdegen [this message]
2019-08-04 12:56 ` Lars Ingebrigtsen
2019-08-04 15:15 ` Štěpán Němec
2019-08-05 6:26 ` Michael Heerdegen
2019-08-05 8:44 ` Štěpán Němec
2019-08-05 9:21 ` Lars Ingebrigtsen
2019-08-18 12:26 ` Michael Heerdegen
2019-08-18 13:32 ` Štěpán Němec
2019-08-18 23:06 ` Lars Ingebrigtsen
2019-08-18 23:50 ` Štěpán Němec
2019-08-19 0:35 ` Drew Adams
2019-08-20 21:49 ` Juri Linkov
2019-08-20 22:44 ` Štěpán Němec
2019-08-21 7:01 ` Stefan Monnier
2019-08-21 8:17 ` Štěpán Němec
2019-08-25 15:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0hl3xqx.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=17871@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.