From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: PATCH: isearch-yank-until-char Date: Wed, 14 Aug 2019 11:41:38 -0500 Message-ID: <87d0h77l8d.fsf@red-bean.com> References: <87tvakfnv4.fsf@red-bean.com> <835zmzsuau.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="115897"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 14 18:41:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hxwLO-000U2g-LU for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2019 18:41:50 +0200 Original-Received: from localhost ([::1]:34256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxwLN-00082q-5f for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2019 12:41:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53973) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxwLG-00082X-FR for emacs-devel@gnu.org; Wed, 14 Aug 2019 12:41:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxwLF-0001DZ-G5 for emacs-devel@gnu.org; Wed, 14 Aug 2019 12:41:42 -0400 Original-Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:45285) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hxwLF-0001DA-Bc for emacs-devel@gnu.org; Wed, 14 Aug 2019 12:41:41 -0400 Original-Received: by mail-ot1-x335.google.com with SMTP id m24so30896294otp.12 for ; Wed, 14 Aug 2019 09:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=F0P1ndK8kqRUNbysNjxgBbwdBs3ZKHxBvn0fm7yQsk8=; b=uCmTGeaLd2stIhbTJQydAfx5gOKIJToT5dXPjBbI6rE+SN5/vNITGC0n10w4fZvbTc eGgh/F+4f28P/IPw3YepB7YnJucssAtfdt370cjn9Dx0FPOnD9FcNBf1mWGtnnGndYnL f8D75PKIiY7FgEFzECPfGDDmMd39QU1cmH1XNTDo7/TOkJtqGYW47v71uhCvRWfBq/M4 54DFeP5infxOBL0CYnwbN/JQdKqo/NXJMdYYnW/YmC+US1CeVn4XNcx74fmcRKx5nKRq yRLaquyR6uX2xo66OSI9Io93CYSvlunUUIu4jzxbECAqIkWUI3HVYcpc0+0z3WtXNZ3O AOcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:reply-to:date :in-reply-to:message-id:user-agent:mime-version; bh=F0P1ndK8kqRUNbysNjxgBbwdBs3ZKHxBvn0fm7yQsk8=; b=e1qXnQkSaKGe812amGpyphbHMQWErYhbLB85VvzbxUhWny6AccGDHpxOMubtXiG9xb LhG8NG4rrmpPAa9aWxALkoECF5ti+BuHMtxiq+vMcmyMJOed/8F7AsW4unXf6+zk3tQw mpPQOXOVobG+UhJGNO6NsYhlXZfvFZpfQZaRxMBbREegGQBDmNwtp+Ac5feTcUtH7fJx NaU1K2HuGdkyGiuQ9sxRJUjdTDuW7+MFSFOKyvjYPZ6FMyVMa93syxVZ4/U/JpRrunhi ++zEAcFfMSmNFPS6/4CjN6oj1A5XwFaTZR3HHXebNxC9SXXMvxCc4tJG5wH7dM8ilbrv 82ug== X-Gm-Message-State: APjAAAXeS5oUjdfUcQvHuWRgriB5iXwPwXXnVcgsLp/1ZXQaPrvZeOFk cUAFHG78ZFwe+UvwqYCRTqNW2H0t X-Google-Smtp-Source: APXvYqzk9H11nRD4WRe8B0XRtiGEgAu/rQll1gX3LRtuElUGkwKHKsSNZmDg8f3NLRLMcZtFoQL3rQ== X-Received: by 2002:a5d:9d43:: with SMTP id k3mr446489iok.111.1565800900068; Wed, 14 Aug 2019 09:41:40 -0700 (PDT) Original-Received: from kwork (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id m4sm211123iok.68.2019.08.14.09.41.39 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 09:41:39 -0700 (PDT) In-Reply-To: <835zmzsuau.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Aug 2019 17:20:09 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239361 Archived-At: On 14 Aug 2019, Eli Zaretskii wrote: >I think it's useful (but please wait for a few days to let others opine). I will. >Please see a few comments to the patch below. > >> --- doc/emacs/search.texi >> +++ doc/emacs/search.texi >> @@ -262,11 +262,17 @@ Isearch Yank >> >> @kindex M-s C-e @r{(Incremental search)} >> @findex isearch-yank-line >> - Similarly, @kbd{M-s C-e} (@code{isearch-yank-line}) appends the rest >> + @kbd{M-s C-e} (@code{isearch-yank-line}) appends the rest >> of the current line to the search string. If point is already at the >> end of a line, it appends the next line. With a prefix argument >> @var{n}, it appends the next @var{n} lines. >> >> +@kindex M-s C-e @r{(Incremental search)} > ^^^^^^^ >> +@findex isearch-yank-line > ^^^^^^^^^^^^^^^^^ >Copy-paste errors, I believe. Yup (embarrassing -- the doc part of the patch is newer than the code, and I must have rushed). Thanks for spotting those. >> + (define-key map [isearch-yank-until-char] >> + '(menu-item "Until char" isearch-yank-until-char > >Our convention is to end with ellipsis any menu item that prompts for >input, so this should be "Until char..." Ah, glad to learn that. Will do. >> + :help "Yank everything until the specified character to search string")) > >I suggest "Yank from point to specified character into search string". Agreed; will do. >This is a new command, so please prepare a NEWS entry as well. Good point; will do. On 14 Aug 2019, Drew Adams wrote: >+1. I think it's very useful. Dunno which key >should be used for it. (I guess C-M-c is OK.) > >> this should be "Until char..." > >[nit] I thought our convention was to use title >case, in which case it would be "Until Char...". The other menu entries there don't seem to be doing title case in this way. Best regards, -Karl