Re: PATCH: isearch-yank-until-char

[Karl Fogel <kfogel@red-bean.com>]

On 14 Aug 2019, Eli Zaretskii wrote:
>I think it's useful (but please wait for a few days to let others opine).

I will.

>Please see a few comments to the patch below.
>
>> --- doc/emacs/search.texi
>> +++ doc/emacs/search.texi
>> @@ -262,11 +262,17 @@ Isearch Yank
>>  
>>  @kindex M-s C-e @r{(Incremental search)}
>>  @findex isearch-yank-line
>> -  Similarly, @kbd{M-s C-e} (@code{isearch-yank-line}) appends the rest
>> +  @kbd{M-s C-e} (@code{isearch-yank-line}) appends the rest
>>  of the current line to the search string.  If point is already at the
>>  end of a line, it appends the next line.  With a prefix argument
>>  @var{n}, it appends the next @var{n} lines.
>>  
>> +@kindex M-s C-e @r{(Incremental search)}
>           ^^^^^^^
>> +@findex isearch-yank-line
>           ^^^^^^^^^^^^^^^^^
>Copy-paste errors, I believe.

Yup (embarrassing -- the doc part of the patch is newer than the code, and I must have rushed).  Thanks for spotting those.

>> +    (define-key map [isearch-yank-until-char]
>> +      '(menu-item "Until char" isearch-yank-until-char
>
>Our convention is to end with ellipsis any menu item that prompts for
>input, so this should be "Until char..."

Ah, glad to learn that.  Will do.

>> +                  :help "Yank everything until the specified character to search string"))
>
>I suggest "Yank from point to specified character into search string".

Agreed; will do.

>This is a new command, so please prepare a NEWS entry as well.

Good point; will do.

On 14 Aug 2019, Drew Adams wrote:
>+1.  I think it's very useful. Dunno which key
>should be used for it.  (I guess C-M-c is OK.)
>
>> this should be "Until char..."
>
>[nit] I thought our convention was to use title
>case, in which case it would be "Until Char...".

The other menu entries there don't seem to be doing title case in this way.

Best regards,
-Karl