From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: Richard Copley <rcopley@gmail.com>, 22072@debbugs.gnu.org
Subject: bug#22072: Error in display-startup-screen if create-image fails
Date: Thu, 26 Sep 2019 18:27:51 +0200 [thread overview]
Message-ID: <87d0fnowe0.fsf@gnus.org> (raw)
In-Reply-To: <86mvttm3hb.fsf@stephe-leake.org> (Stephen Leake's message of "Wed, 02 Dec 2015 06:36:48 -0600")
Stephen Leake <stephen_leake@stephe-leake.org> writes:
> Richard Copley <rcopley@gmail.com> writes:
>
> Can you test this patch:
[...]
> - (let* ((img (create-image (fancy-splash-image-file)))
> - (image-height (and img (cdr (image-size img nil frame))))
> - ;; We test frame-height so that, if the frame is split
> - ;; by displaying a warning, that doesn't cause the normal
> - ;; splash screen to be used.
> - (frame-height (1- (frame-height frame))))
> - (> frame-height (+ image-height 19)))))))
> + (let ((img (create-image (fancy-splash-image-file))))
> + (image-height (and img (cdr (image-size img nil frame))))
> + ;; We test frame-height so that, if the frame is split
> + ;; by displaying a warning, that doesn't cause the normal
> + ;; splash screen to be used.
> + (frame-height (and img (1- (frame-height frame)))))
> + (and img (> frame-height (+ image-height 19))))))))
I've now fixed this on the trunk inspired by this patch, but slightly
differently.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-09-26 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 1:53 bug#22072: Error in display-startup-screen if create-image fails Richard Copley
2015-12-02 12:36 ` Stephen Leake
2015-12-02 20:07 ` Richard Copley
2019-09-26 16:27 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0fnowe0.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22072@debbugs.gnu.org \
--cc=rcopley@gmail.com \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.