From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4422: diff-switches is a bad idea Date: Tue, 01 Oct 2019 15:18:29 +0200 Message-ID: <87d0fg7gey.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1536"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 4422@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 15:21:59 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFI6I-0000Dv-UB for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 15:21:59 +0200 Original-Received: from localhost ([::1]:41992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFI6H-0002yv-3R for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 09:21:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54192) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFI3W-0000TX-3I for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:19:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFI3U-0001kt-R6 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:19:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFI3U-0001kh-NV for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:19:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFI3S-0007B4-4p for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:19:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs Original-Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.156993591627542 (code B ref 4422); Tue, 01 Oct 2019 13:19:02 +0000 Original-Received: (at 4422) by debbugs.gnu.org; 1 Oct 2019 13:18:36 +0000 Original-Received: from localhost ([127.0.0.1]:32851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFI31-0007AA-UG for submit@debbugs.gnu.org; Tue, 01 Oct 2019 09:18:36 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFI2z-00079y-Dk for 4422@debbugs.gnu.org; Tue, 01 Oct 2019 09:18:33 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFI2v-0003AG-7c; Tue, 01 Oct 2019 15:18:31 +0200 In-Reply-To: (Reuben Thomas's message of "Sun, 13 Sep 2009 13:18:03 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167993 Archived-At: Reuben Thomas writes: > I'm using Emacs 23, and I have just been puzzling over why vc-diff > stopped working in CVS checkouts. I eventually traced it to > diff-switches: I have mine set to "-Nur", quite reasonably, I think, > but of course "-r" means something quite different to CVS, and I ended > up with a hard-to-understand error message about tags. > > I suggest not using diff-switches (this would also remove some > special-case code, as no other vc command respects a non-vc option > like this.) Yes, some users will have to configure the same thing in > two places, but others will be saved the confusion I had. For the > switches to be commoned up sensibly, a more structured approach to > setting them is needed that takes semantics into account, and that way > lies madness. (I'm going through old bug reports that unfortunately didn't get any response at the time.) I'm not extremely familiar with the vc code, but looking at it in Emacs 27, at least, the switches for diff in CVS comes from vc-cvs-diff-switches, if I read the `vc-switches' function correctly. So has this problem gone away in the years since this was reported? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no