From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#31497: 27.0.50; vc-hg doesn't separate standard error from standard output Date: Wed, 09 Oct 2019 23:57:15 +0200 Message-ID: <87d0f51t1g.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161103"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31497@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 23:59:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIJzQ-000fnX-3m for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 23:59:24 +0200 Original-Received: from localhost ([::1]:60364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIJzO-000204-R6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 17:59:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54980) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIJy8-0000tV-0E for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:58:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIJy6-00026H-Pi for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIJy6-00026D-MV for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIJy6-0003Om-Bl for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31497 X-GNU-PR-Package: emacs Original-Received: via spool by 31497-submit@debbugs.gnu.org id=B31497.157065824113005 (code B ref 31497); Wed, 09 Oct 2019 21:58:02 +0000 Original-Received: (at 31497) by debbugs.gnu.org; 9 Oct 2019 21:57:21 +0000 Original-Received: from localhost ([127.0.0.1]:54315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIJxR-0003Ng-JZ for submit@debbugs.gnu.org; Wed, 09 Oct 2019 17:57:21 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:45188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIJxP-0003NY-Pi for 31497@debbugs.gnu.org; Wed, 09 Oct 2019 17:57:20 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIJxL-00056Y-GC; Wed, 09 Oct 2019 23:57:18 +0200 In-Reply-To: (Philipp Stephani's message of "Fri, 18 May 2018 19:42:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168807 Archived-At: Philipp Stephani writes: > Create a Mercurial repository owned by root and add a hgrc file, e.g.: > > $ mkdir -p /tmp/hg > $ cd /tmp/hg > $ sudo -s > # hg init > # echo a > a.txt > # hg addremove > # hg commit -m 'commit message' > # touch .hg/hgrc > > Then visit a.txt in Emacs as non-root: > > $ emacs -Q a.txt > > Instead of the revision number, the status line will show > "Hg-not trusting file /tmp/hg/.hg/hgrc ..." > > This is because the status line runs something like > > $ hg log -l 1 -r . -T '{rev}' > > but that outputs > > not trusting file /tmp/hg/.hg/hgrc from untrusted user root, group root > not trusting file /tmp/hg/.hg/hgrc from untrusted user root, group root > > on stderr, and Emacs merges stderr and stdout. Rather it should ignore > stderr in this case. I can confirm that this bug is still present in Emacs 27. The command is started from vc-doc-command, which uses start-file-process, which uses start-process, which doesn't even allow separating stderr from stdin. (In general, Emacs stderr/stdin handling is very frustrating.) Would it make sense to alter this function (defun vc-hg--run-log (template rev path) (ignore-errors (with-output-to-string (if path (vc-hg-command standard-output 0 nil "log" "-f" "-l1" "--template" template path) (vc-hg-command standard-output 0 nil "log" "-r" rev "-l1" "--template" template))))) to filter out the "not trusting" lines, or is this just one of a gazillion error messages that can be output here? not trusting file /tmp/hg/.hg/hgrc from untrusted user root, group root not trusting file /tmp/hg/.hg/hgrc from untrusted user root, group root 4d872e I though perhaps we could redirect the error output with "-E", but "hg log" doesn't seem to support that. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no