From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 27 Nov 2019 23:30:04 +0200 Organization: LINKOV.NET Message-ID: <87d0dd88jr.fsf@mail.linkov.net> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255477"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 37774@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 27 22:57:57 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ia5Js-0014IO-Bp for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 22:57:56 +0100 Original-Received: from localhost ([::1]:43562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia5Jr-0001ch-4s for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 16:57:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51979) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia5J2-0000zN-9I for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:57:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ia5J0-0002Ed-S4 for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:57:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ia5J0-0002EK-KD for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ia5J0-0008AE-J1 for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 16:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2019 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157489177031257 (code B ref 37774); Wed, 27 Nov 2019 21:57:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 27 Nov 2019 21:56:10 +0000 Original-Received: from localhost ([127.0.0.1]:56299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5IA-000885-Cp for submit@debbugs.gnu.org; Wed, 27 Nov 2019 16:56:10 -0500 Original-Received: from cheetah.birch.relay.mailchannels.net ([23.83.209.34]:15493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ia5I9-00087x-6h for 37774@debbugs.gnu.org; Wed, 27 Nov 2019 16:56:09 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 36F3C600962; Wed, 27 Nov 2019 21:56:08 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-6-199.trex.outbound.svc.cluster.local [100.96.6.199]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BD9F0600F8D; Wed, 27 Nov 2019 21:56:07 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 27 Nov 2019 21:56:08 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Suffer-Power: 30bc6a3d15bb1325_1574891768004_240843578 X-MC-Loop-Signature: 1574891768003:1029479977 X-MC-Ingress-Time: 1574891768003 Original-Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id CCFC69C43F; Wed, 27 Nov 2019 13:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=lgfyhdwdWD5WeoxS7NcEn8Vz90I=; b= TUU5UYNh3KIwGE4gOY9f6yZSIXZZGZrrMrnHndOFOGjnXoy8shP6SWJ+v7jgbsTZ kI7DCk0vuP0avltraRJ4QCNcqJ6U+WSchsJWPWkmInczEBuFlDoAdzj+blcGu2l8 wYWv0B/wha0C+cpZHcIGISFKJDQyi2QfOWYyIyoGzFA= Original-Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id 6FC339C456; Wed, 27 Nov 2019 13:55:59 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a94 In-Reply-To: (Dmitry Gutov's message of "Tue, 26 Nov 2019 01:50:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172563 Archived-At: >>> BTW, the diff-context needs ':extend t' as well. >> Feel free to make that change (although when did you last see a >> context diff?). > > It's not for context diffs, it's for context around the changes in unified > diffs as well. Notice the gray background on the screenshot. diff-context by default is just '((t nil)) Where do you think to add ':extend t'? To empty face definition? >>> But that's of little importance since as soon as I load a custom >>> theme, whatever defaults were there don't seem to matter. >> >> We need to modify all the themes we provide to specify :extend for >> faces where we do that by default. It seems there's no way around >> that, since the semantics of custom-theme-set-faces is clearly to >> reset all face attributes to 'unspecified' before applying the face >> spec, so keeping some attributes from the default face spec is out of >> the question, unfortunately. It's clear that the faces stuff was not >> designed to accommodate addition of attributes easily. This means manually adding :extend to all files in etc/themes?