From: Tino Calancha <tino.calancha@gmail.com>
To: "Tassilo Horn" <tsdh@gnu.org>
Cc: 39546@debbugs.gnu.org, michael.albinus@gmx.de, larsi@gnus.org
Subject: bug#39546: 28.0.50; Do not require subr-x at run time
Date: Mon, 10 Feb 2020 21:49:18 +0100 [thread overview]
Message-ID: <87d0amyxpt.fsf@gmail.com> (raw)
In-Reply-To: <87ftfiyye1.fsf@gmail.com> (Tino Calancha's message of "Mon, 10 Feb 2020 21:34:46 +0100")
Tino Calancha <tino.calancha@gmail.com> writes:
> "Tassilo Horn" <tsdh@gnu.org> writes:
>
>> Am Mo, 10. Feb 2020, um 20:30, schrieb Tino Calancha:
>>> replace.el is a good agreement between subr-x.el (it's a defun, so
>>> it doesn't fit well there) and subr.el.
>>>
>>> As subr.el, replace.el is also loaded at start time, but it's ~ half size,
>>> and more important than that, it's all about replacing in Emacs.
>>
>> Sounds good to me!
>
> Here is the updated patch:
> - It deletes the cookie from subr-x (yes, we have one for when-let)
> - Move replace-region-contents inside replace.el (loaded at startup)
> - Add all required (eval-when...(req.. 'subr-x)) at tramp files
> - Replaced loading subr-x at run time with compile time for some other files
>
> I have run the testsuite without surprises.
Well, actually there was a surprise, but who don't like surprises after
all!
I missed this one (it was relying on the whe-let cookie):
diff --git a/lisp/image/exif.el b/lisp/image/exif.el
index 642bc58321..27ad616146 100644
--- a/lisp/image/exif.el
+++ b/lisp/image/exif.el
@@ -62,6 +62,7 @@
;;; Code:
(require 'cl-lib)
+(eval-when-compile (require 'subr-x))
(defvar exif-tag-alist
'((11 processing-software)
next prev parent reply other threads:[~2020-02-10 20:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:59 bug#39546: 28.0.50; Do not require subr-x at run time Tino Calancha
2020-02-10 14:54 ` Michael Albinus
2020-02-10 17:35 ` Tino Calancha
2020-02-10 15:31 ` Eli Zaretskii
2020-02-10 17:26 ` Tino Calancha
2020-02-10 17:39 ` Eli Zaretskii
2020-02-10 19:19 ` Tassilo Horn
2020-02-10 19:59 ` Eli Zaretskii
2020-02-10 20:17 ` Tassilo Horn
2020-02-10 19:30 ` Tino Calancha
2020-02-10 19:54 ` Tassilo Horn
2020-02-10 20:34 ` Tino Calancha
2020-02-10 20:49 ` Tino Calancha [this message]
2020-02-10 21:00 ` Tino Calancha
2020-02-14 10:16 ` Eli Zaretskii
2020-02-19 13:41 ` Lars Ingebrigtsen
2020-08-08 14:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0amyxpt.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=39546@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.