From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#40808: 27.0.91; inaccuracy in isearch-lazy-count Date: Mon, 04 May 2020 01:33:04 +0300 Organization: LINKOV.NET Message-ID: <87d07k1wgr.fsf@mail.linkov.net> References: <41ce1bd9-2ddb-a46b-3cb9-2b1b25e48438@net-c.com> <87ftcrux08.fsf@mail.linkov.net> <83o8rb1kra.fsf@gnu.org> <87mu6vkvz5.fsf@mail.linkov.net> <83ftcm22c0.fsf@gnu.org> <874kt2586b.fsf@mail.linkov.net> <87y2qcsp6n.fsf@mail.linkov.net> <83k11ww61j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="46948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 40808@debbugs.gnu.org, abdullah@net-c.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 04 00:34:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVNBi-000C59-3R for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 May 2020 00:34:18 +0200 Original-Received: from localhost ([::1]:52294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVNBh-0007Zr-0M for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 May 2020 18:34:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVNBT-0007ZO-2X for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 18:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVNBS-0001T3-PL for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 18:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVNBS-000451-N8 for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 18:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 May 2020 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40808 X-GNU-PR-Package: emacs Original-Received: via spool by 40808-submit@debbugs.gnu.org id=B40808.158854520115623 (code B ref 40808); Sun, 03 May 2020 22:34:02 +0000 Original-Received: (at 40808) by debbugs.gnu.org; 3 May 2020 22:33:21 +0000 Original-Received: from localhost ([127.0.0.1]:58347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVNAn-00043v-Gi for submit@debbugs.gnu.org; Sun, 03 May 2020 18:33:21 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:60699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVNAl-00043e-D7 for 40808@debbugs.gnu.org; Sun, 03 May 2020 18:33:19 -0400 Original-Received: from mail.gandi.net (m91-129-106-11.cust.tele2.ee [91.129.106.11]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 3D5FA200004; Sun, 3 May 2020 22:33:11 +0000 (UTC) In-Reply-To: <83k11ww61j.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 01 May 2020 08:58:00 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179635 Archived-At: >> I'm still unsure about pushing this change. The current state of things: >> >> - in emacs-27 and master now it counts all matches, including invisible, >> regardless of the value of search-invisible; >> >> - the proposed change for master doesn't include in the count these >> invisible matches that can't be visited by opening overlays; >> >> - but this fix is pointless for org-mode where visiting invisible >> matches is broken, and where its count varies after visiting >> and opening hidden overlays. > > Would it be possible to fix the breakage in Org on master? We need help from Org developers to fix the breakage in Org. Meanwhile, I reverted a part of the recent fix on emacs-27 that tried to fix a long-standing corner case of lazy-highlighting in outlines, but whose side-effect might slow down lazy-highlighting in collapsed outlines. This needs more testing on master. Whereas the fix for isearch-lazy-count still remains in the release branch.