From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Jamie Beardslee Newsgroups: gmane.emacs.help Subject: Re: trouble overwriting C-r in a shell (term-mode) Date: Fri, 29 May 2020 21:09:03 +1200 Message-ID: <87d06nnm4w.fsf@gmail.com> References: <87imgflrwi.fsf@gmail.com> <87367jn0jy.fsf@ebih.ebihd> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="89475"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:+Bm+3EjlRtnHD/dgkvPqfjudsYI= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 29 11:15:31 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeb6w-000NAR-1o for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 29 May 2020 11:15:30 +0200 Original-Received: from localhost ([::1]:37570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeb6v-0005Pk-4t for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 29 May 2020 05:15:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeb6Z-0005OO-MK for help-gnu-emacs@gnu.org; Fri, 29 May 2020 05:15:07 -0400 Original-Received: from ciao.gmane.io ([159.69.161.202]:46146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeb6Z-00033q-3M for help-gnu-emacs@gnu.org; Fri, 29 May 2020 05:15:07 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jeb6U-000MfY-FS for help-gnu-emacs@gnu.org; Fri, 29 May 2020 11:15:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=159.69.161.202; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/29 04:14:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:123172 Archived-At: > Style points: > > "\C-r" instead of (kbd "C-r") > > `let' so the hard-coded data item "*Open Recent*" > appears onee time > > `when' instead of `if' as there is no else branch Even more style points: - don't bind a key to an anonymous function - buffer name is dependent on `recentf-menu-title' - use an informative docstring (defun my-recentf-open-files () "blah blah blah" (interactive) (let ((buffer (get-buffer (format "*%s*" recentf-menu-title)))) (when buffer (kill-buffer buffer)) (recentf-open-files))) (define-key term-raw-map (kbd "C-r") #'my-recentf-open-files)