From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Cc: bug#38421 <38421@debbugs.gnu.org>
Subject: Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil
Date: Sun, 19 Jul 2020 17:20:08 +0200 [thread overview]
Message-ID: <87d04rpm53.fsf@gnus.org> (raw)
In-Reply-To: <m2woavp0vb.fsf@fastmail.fm> (Filipp Gunbin's message of "Tue, 17 Dec 2019 15:55:52 +0300")
Filipp Gunbin <fgunbin@fastmail.fm> writes:
> Could someone please review the patch? (bug#38421)
>
> It's simple, but I'm not sure about using gnus-visual-p in mm-* files.
I don't think we can use that function there, because these are general
utility functions (used by mh-e, for instance).
As the comment in mm-view.el says:
;; Shouldn't these functions check whether the user even wants to use
;; font-lock?
They should, indeed. But I'm not quite sure what the correct approach
for the application (that is Gnus) to inhibit these functions...
What functions to use is decided by mm-inline-media-tests, and there's
no way to use one version if we want highlights and another if we
don't...
Anybody got any ideas here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-07-19 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 19:08 bug#38421: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil Filipp Gunbin
2019-11-28 21:48 ` bug#38421: Status: " Filipp Gunbin
2019-12-17 12:55 ` Filipp Gunbin
2020-07-19 15:20 ` Lars Ingebrigtsen
2020-07-19 15:20 ` Lars Ingebrigtsen [this message]
2020-08-02 17:45 ` Lars Ingebrigtsen
2020-08-02 17:45 ` Lars Ingebrigtsen
2020-08-07 18:13 ` Filipp Gunbin
2019-12-17 12:55 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d04rpm53.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=38421@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.