all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, akater <nuclearspace@gmail.com>
Subject: Re: [PATCH] org-element: Hide parsers boilerplate into plist-creating macros
Date: Wed, 09 Sep 2020 18:11:38 +0200	[thread overview]
Message-ID: <87d02vlykl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r1rbl4ll.fsf@gnu.org> (Bastien's message of "Wed, 09 Sep 2020 10:46:46 +0200")

Hello,

Bastien <bzg@gnu.org> writes:

> akater <nuclearspace@gmail.com> writes:
>
>> We replace some repetetive code with macro calls org-prog-plist and
>> org-let*-prog-plist.
>
> IIUC this is a refactoring, it does not add or remove functionalities?
>
> I'll let Nicolas decide on this, of course.

FWIW, I'm not convinced there's a significant advantage in doing this
refactoring. Arguably, the code is not more readable. It will not make
it faster either.

There is room for refactoring in Org (for the record, org-agenda.el has
not switched to lexical binding yet), but I don't think org-element.el
has bitrotten so much that it deserves some.

Regards,
-- 
Nicolas Goaziou


      parent reply	other threads:[~2020-09-09 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 17:19 [PATCH] org-element: Hide parsers boilerplate into plist-creating macros akater
2020-09-09  8:46 ` Bastien
2020-09-09 13:59   ` akater
2020-09-09 14:37     ` Bastien
2020-09-09 16:11   ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d02vlykl.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=nuclearspace@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.