From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 17954@debbugs.gnu.org, 6542@debbugs.gnu.org
Subject: bug#6542: bug#17954: 24.4.50; [patch] `menu-bar-make-toggle' should allow for keywords
Date: Sat, 19 Sep 2020 18:24:37 +0200 [thread overview]
Message-ID: <87d02hohtm.fsf@gnus.org> (raw)
In-Reply-To: <9e5b6c5f-0dd9-44ef-b997-3cc032e7a107@default> (Drew Adams's message of "Sat, 5 Jul 2014 22:28:37 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> `menu-bar-make-toggle' handles no keywords. It takes the value of
> :help as an explicit argument (without keyword), but it does not pass
> along :keys, :active, :enable, etc. to `menu-item'. It should.
>
> It cannot accept keywords in the normal way because it defines BODY as
> an &rest parameter. This mistake should be corrected, making for an
> incompatible change unfortunately, in order to allow a KEYWORDS &rest
> parameter.
>
> BODY is seldom used. In the Emacs Lisp sources, there are only these
> two occurrences of `menu-bar-make-toggle' that use BODY:
> `toggle-save-place-globally' and `toggle-uniquify-buffer-names'. They
> would just need to wrap the current BODY code in an explicit `progn'.
I've now applied your patch, but renamed the resulting macro to
menu-bar-make-toggle-command, while the former name is now an obsolete
wrapper macro. I've also adjusted all in-tree callers.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-09-19 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 5:28 bug#17954: 24.4.50; [patch] `menu-bar-make-toggle' should allow for keywords Drew Adams
2016-04-27 22:05 ` bug#6542: " Lars Ingebrigtsen
2020-09-19 16:24 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d02hohtm.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=17954@debbugs.gnu.org \
--cc=6542@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.