From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30990: Should the byte compiler warn about :type mismatches? Date: Fri, 25 Sep 2020 15:18:47 +0200 Message-ID: <87d02aouyw.fsf@gnus.org> References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 25 15:24:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLniP-0005Zp-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 15:24:45 +0200 Original-Received: from localhost ([::1]:46636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLniO-00079w-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 09:24:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLndq-0001kR-6e for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 09:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLndp-0004wB-Rd for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 09:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLndp-0000FT-MQ for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 09:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Sep 2020 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30990 X-GNU-PR-Package: emacs Original-Received: via spool by 30990-submit@debbugs.gnu.org id=B30990.1601039943884 (code B ref 30990); Fri, 25 Sep 2020 13:20:01 +0000 Original-Received: (at 30990) by debbugs.gnu.org; 25 Sep 2020 13:19:03 +0000 Original-Received: from localhost ([127.0.0.1]:43039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLncs-0000EB-E2 for submit@debbugs.gnu.org; Fri, 25 Sep 2020 09:19:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLncp-0000Dg-SW for 30990@debbugs.gnu.org; Fri, 25 Sep 2020 09:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FtRMrNrjSkQcjgH9gIBdBCpM+10cxZy8Z3V2vntQKcU=; b=LTtHUPIqKiUToHM4Nj6PqgXlwZ 2A4TGrc3gVZu5jgxXUlzGHpfe9SAjhVcbL2yAQsXeadYxmfv/A82ZwLImBOPiQxgbXxxJf6A4l76f M0TE8xpirt/iqXzO1WdHOJvHqiNNMIa/nQ2Fk7alB5DOz4mwREIJj7HSDj/dH2cjfmbw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLncf-0002cD-6O; Fri, 25 Sep 2020 15:18:52 +0200 X-Now-Playing: Herbert's _Suddenly_: "Suddenly (Herbert Redub)" In-Reply-To: (Robert Pluim's message of "Thu, 10 Oct 2019 15:11:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188968 Archived-At: Robert Pluim writes: > Except that the underlying type is '(repeat ....) so I wonder if this: > > (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) > (unless wallet > (setq w (locate-user-emacs-file (concat "sql-wallet" ext) > (concat ".sql-wallet" ext))) > (when (file-exists-p w) > (setq wallet w))))) ; <= this returns a string > > should use (setq wallet (list w)) instead I went ahead and fixed this along with a bunch of other warnings revealed by the test (that has snuck in after Rober fixed the last batch, I think). There's some that are rather intractable, though, like sql-postgres-login-params. These remain: whitespace-indentation-regexp whitespace-space-after-tab-regexp sql-postgres-login-params gdb-display-source-buffer-action I don't quite understand what's wrong here: (defcustom whitespace-indentation-regexp '("^\t*\\(\\( \\{%d\\}\\)+\\)[^\n\t]" . "^ *\\(\t+\\)[^\n]") [...] :type '(cons (regexp :tag "Indentation SPACEs") (regexp :tag "Indentation TABs")) :group 'whitespace) Isn't that how you specify a cons of two values? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no