From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) Newsgroups: gmane.emacs.devel Subject: Re: master 2e090da: Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. Date: Mon, 26 Oct 2020 10:47:54 +0100 Message-ID: <87d015jp2t.fsf@hajtower> References: <20201025101403.1168.4440@vcs0.savannah.gnu.org> <20201025101404.7EBE2204DA@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Philipp Stephani , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 26 10:48:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWz7Q-0002wP-2C for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Oct 2020 10:48:48 +0100 Original-Received: from localhost ([::1]:45220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWz7P-0001YR-4p for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Oct 2020 05:48:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWz6h-0000gT-7Z for emacs-devel@gnu.org; Mon, 26 Oct 2020 05:48:03 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:59440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWz6e-00084s-Dd for emacs-devel@gnu.org; Mon, 26 Oct 2020 05:48:02 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E520E16005F for ; Mon, 26 Oct 2020 10:47:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603705675; bh=RnaVEgWrBggzYGhdUPFUA1eX3u+DeIEMjfbPSBWurnA=; h=From:To:Cc:Subject:Date:From; b=qLbGSyXqZiFjItzos/l+ZkD1uGBJtmQcYDwuc8sB5SQgDLQ3kQ6mrWwLKn7AnoRLR axQoxS29ElhR8IEiF1J0Rej1mvdYU7LKHGoC//ZfjKT6bnwlzpM7+9uVhGVD/xOuNh VConE4cKUBNsPX+9fxwuyLHXxIGoC4RacZ96k+G16vqoG3wsgeLMtzs2SU83IY5fcr b96hwB1HgNqv0Qye7G9/fLJNtK27jTXFOURSu3obYwe7qmjJHEUEjYOcA9NRZyWFxP 4epTty+OYJtNItzZ1YuNpoHZYvzJSv89ixzK4yiKnDrP2jq2jG2P7bHyPYeUlminBS +/qUmxqpfnwMw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CKVPl1H3jz6tmL; Mon, 26 Oct 2020 10:47:55 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Sun, 25 Oct 2020 09:59:05 -0400") Received-SPF: pass client-ip=185.67.36.65; envelope-from=haj@posteo.de; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 05:47:56 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258455 Archived-At: Stefan Monnier writes: >> Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. >> Flymake supports all Emacs versions back to 26.1, so it can=E2=80=99= t use >> =E2=80=98ert-resource-file=E2=80=99. >> * test/lisp/progmodes/flymake-tests.el (flymake-tests-data-directory= ): >> Recreate. >> (flymake-tests--call-with-fixture): Stop using =E2=80=98ert-resource= -file=E2=80=99. > > It's common for a package to say "require Emacs version NN.MM" but to > provide extra features on more recent Emacsen. And the tests can > definitely fall into the category of extra features. I have also been bitten by this and am pondering what's the best way out of that dilemma. I'm working on cperl-mode and am trying to keep it compatible with Emacs 26.1 (the version which comes with Debian stable). cperl-mode isn't even on ELPA yet, but might end up there. I *really* like 'ert-resource-file' because it reduces a lot of boilerplate from the tests. Therefore I don't consider reverting that commit. However, for the moment, I lost the chance to run the tests in the environment which comes with Emacs "as shipped by the distributions". In my opinion, running the tests in older versions _is_ important, otherwise the claim "supports Emacs 26.1" isn't honest. I want to support older Emacsen so that I can get feedback from users who don't want to compile their own Emacs (which includes myself on production systems), and I also want to add new features for which new tests should be written. So, what I've come up with is a file ert-backport.el, with the description "Run ERT tests from Emacs master under older Emacsen". To activate this file, I add its directory to the environment variable EMACSLOADPATH - and voila, tests from Emacs' master branch pass with Debian buster's Emacs 26, using the ERT provided by this Debian package. Whenever the tests are upgraded to use new ERT features (which I consider to be rare events anyway), ert-backport.el needs to be updated. Could such an ert-backport.el be a candidate for ELPA? It should be useful for all dual-life (Emacs + ELPA) packages. -- Cheers, haj