From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Wed, 18 Nov 2020 21:43:28 +0200 Organization: LINKOV.NET Message-ID: <87d00acuh3.fsf@mail.linkov.net> References: <20201115023629.19537.77471@vcs0.savannah.gnu.org> <20201115023631.C78AB20A27@vcs0.savannah.gnu.org> <20201115224943.o5r7lkkblmyt2ox4@Ergus> <20201116033719.63dryvqm4ozfer2r@Ergus> <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> <20201116102729.ywubtda6cqdzc45z@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14086"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 18 21:04:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfTh6-0003XJ-25 for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 21:04:44 +0100 Original-Received: from localhost ([::1]:48314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfTh5-0008Ae-3Q for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 15:04:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfTcg-00057t-Sc for emacs-devel@gnu.org; Wed, 18 Nov 2020 15:00:10 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfTce-0006qv-RF for emacs-devel@gnu.org; Wed, 18 Nov 2020 15:00:10 -0500 X-Originating-IP: 91.129.97.46 Original-Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B5197FF80A; Wed, 18 Nov 2020 20:00:04 +0000 (UTC) In-Reply-To: <20201116102729.ywubtda6cqdzc45z@Ergus> (Ergus's message of "Mon, 16 Nov 2020 11:27:29 +0100") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 15:00:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259385 Archived-At: > The code is extremely simple, so, if you think you could improve > anything it is more tan welcome. The branch contains many different features with different problems, so here is a short summary for these 4 separate features: 1. feature of setting minibuffer-tab-through-completions-function to completions-highlight-minibuffer-tab-through-completions: The problem is that such TAB cycling is limited only to the case when the whole *Completions* buffer is visible. The original behavior of multiple presses of TAB is limited too: its browsing is uni-directional, there is no way to use S-TAB to scroll completions backwards. So I don't see how relying on TAB could improve navigation in completions. 2. completion-set-suffix sometimes doesn't work; 3. commands that dispatch navigation keys from the minibuffer to the *Completions* buffer: this doesn't cover other navigation keys. Maybe like windmove-default-keybindings defines modifiers, a similar function could set up modifiers for scrolling completions from the minibuffer, then the users could choose whether to use e.g. 'M-' modifier for scrolling completions, or no modifier at all. 4. the feature of using completions-highlight-overlay often fails to update highlighting when point is moved in the *Completions* buffer by other navigation commands. To fix this, it could work like hl-line-mode, but instead of highlighting the whole line, it could highlight only completions. Then completion highlighting would be useful on its own. A new defcustom e.g. 'completion-highlight' (disabled by default) could add a post-command-hook like hl-line-mode does. Then other completion commands could enable this variable locally.