all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 45a1653: ; Fix last change to bibtex.el
Date: Wed, 18 Nov 2020 11:47:44 +0000	[thread overview]
Message-ID: <87d00a28f3.fsf@tcd.ie> (raw)
In-Reply-To: <h0sg97a19h.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 17 Nov 2020 20:42:50 -0500")

Glenn Morris <rgm@gnu.org> writes:

>> commit 45a1653afa8eb0032908bc94b5466604f84805d5
>
>> diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
>> index b69d715..d53cfa0 100644
>> --- a/lisp/textmodes/bibtex.el
>> +++ b/lisp/textmodes/bibtex.el
>
> [...]
>
>> -		 (function :tag "Conversion function")))
>> -(make-variable-buffer-local 'bibtex-unify-case-convert)
>> +                 (function :tag "Conversion function"))
>> +  :local t)
>
> After this change:
>
> bibtex-unify-case-convert:
>   Its value is nil
>   Original value was ‘identity’
>
> The "nil" value causes a test failure: https://hydra.nixos.org/build/130666989
>
> (Perhaps defcustom's recently added :local feature, of which this is the
> only user, is broken.)

Right.  I'll remove the :local for now, as per Roland's suggestion, and
see if I can get the tag working as intended later.

Thanks,

-- 
Basil



  parent reply	other threads:[~2020-11-18 11:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201116233108.21940.22514@vcs0.savannah.gnu.org>
     [not found] ` <20201116233110.4E83E209DE@vcs0.savannah.gnu.org>
2020-11-18  1:42   ` master 45a1653: ; Fix last change to bibtex.el Glenn Morris
2020-11-18  4:19     ` Roland Winkler
2020-11-18 12:30       ` Basil L. Contovounesios
2020-11-18 14:13         ` Roland Winkler
2020-11-18 14:36           ` Roland Winkler
2020-11-18 16:35           ` Basil L. Contovounesios
2020-11-18 17:11             ` Roland Winkler
2020-11-18 21:31               ` Stefan Monnier
2020-11-18 21:56                 ` Roland Winkler
2020-11-28 22:32                   ` Roland Winkler
2020-11-19  5:23               ` Richard Stallman
2020-11-19  8:25                 ` Roland Winkler
2020-11-18 11:47     ` Basil L. Contovounesios [this message]
2020-11-18 16:18       ` Basil L. Contovounesios
2020-11-24  6:31         ` Lars Ingebrigtsen
2020-11-24 15:35           ` Eli Zaretskii
2020-11-24 19:26             ` Basil L. Contovounesios
2020-11-24 19:58               ` Eli Zaretskii
2020-11-24 20:25                 ` Eli Zaretskii
2020-11-24 21:01                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d00a28f3.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.