From: Juri Linkov <juri@linkov.net>
To: clemera@posteo.net
Cc: 45234@debbugs.gnu.org
Subject: bug#45234: Annotation function vs. Affixation function
Date: Mon, 14 Dec 2020 21:31:06 +0200 [thread overview]
Message-ID: <87czzc5n7x.fsf@mail.linkov.net> (raw)
In-Reply-To: <c65a9a6d-6e4f-5e0a-b681-c17363f1e6bc@posteo.de> (clemera@posteo.net's message of "Mon, 14 Dec 2020 12:07:04 +0100")
> On current master the results of the new annotation function are passed to
> the affixation function in minibuffer-completion-help:
>
> (when ann-fun
> (setq completions
> (mapcar (lambda (s)
> (let ((ann (funcall ann-fun s)))
> (if ann (list s ann) s)))
> completions)))
> (when aff-fun
> (setq completions
> (funcall aff-fun completions)))
>
> If the annotation function returns a result it's packed into a list
> which should be an unexpected format for the affixation function?
> Maybe when both are defined only the affixation function should be used?
The current implementation assumes that the affixation function
can be smart enough to recognize that completions were modified
by a previous call of the annotation function.
If you can demonstrate that this is not always the case, then
the implementation could be changed, there is enough time before
the next release, after that it would be harder to change this.
next prev parent reply other threads:[~2020-12-14 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 11:07 bug#45234: Annotation function vs. Affixation function clemera
2020-12-14 11:53 ` Clemens
2020-12-14 19:31 ` Juri Linkov [this message]
2020-12-15 12:35 ` Clemens
2020-12-15 20:19 ` Juri Linkov
2020-12-15 21:06 ` Clemens
2020-12-16 21:20 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czzc5n7x.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=45234@debbugs.gnu.org \
--cc=clemera@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.