all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Tue, 15 Dec 2020 20:58:35 -0600	[thread overview]
Message-ID: <87czzaxxr8.fsf@alphapapa.net> (raw)
In-Reply-To: 83eejscsg0.fsf@gnu.org

Eli Zaretskii <eliz@gnu.org> writes:

>> AFAIK there's no way to inherit only a certain attribute of a face,
>> other than using an anonymous face made at runtime.  If there were, it
>> would be simple to just inherit the mode-line face's background color.
>
> I'm not sure I understand why would want to inherit just the
> background color.  What's wrong with inheriting all the rest?

I would guess that the mode-line face could have other attributes that
we wouldn't want to interfere with the tab-line faces, e.g. size or
family.  The only reason I would want to inherit from mode-line is to
get the background color.

Since this doesn't seem advisable, I've changed the definition of the
tab-line-tab-special face to define the background color explicitly,
using one which is slightly darker than the tab-line face's default.

>> >> +(defface tab-line-tab-special '((t (:slant italic)))
>> >
>> > What will this do on terminals that don''t support italic?
>> 
>> Nothing, I suppose.  :)  I don't often use Emacs in a terminal, so I'm
>> not as familiar with that issue.
>> 
>> I'll be glad to follow whatever guidance you may provide here.  Thanks.
>
> I guess if italics isn't supported, you could use bold or some
> foreground color instead?

Sure.  I've changed the face definition to only use italic on terminals
that support it, and to default to bold otherwise.

These changes will be in the next patch version.  Thanks.




  reply	other threads:[~2020-12-16  2:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13  6:04 [PATCH] tab-line-alternate-colors Adam Porter
2020-12-13  6:17 ` Adam Porter
2020-12-13  8:45 ` Juri Linkov
2020-12-13 10:06   ` Adam Porter
2020-12-13 11:13     ` Adam Porter
2020-12-13 15:21     ` Eli Zaretskii
2020-12-14  2:17       ` Adam Porter
2020-12-14 15:34         ` Eli Zaretskii
2020-12-16  2:58           ` Adam Porter [this message]
2020-12-16 15:41             ` Eli Zaretskii
2020-12-13 21:25     ` Juri Linkov
2020-12-14  4:33       ` Adam Porter
2020-12-14  9:10         ` Juri Linkov
2020-12-14 10:05           ` Adam Porter
2020-12-14 19:37             ` Juri Linkov
2020-12-16  3:24               ` Adam Porter
2020-12-16  3:55                 ` Adam Porter
2020-12-16  9:03                 ` Juri Linkov
2020-12-16 10:26                   ` Adam Porter
2020-12-16 20:46                     ` Juri Linkov
2020-12-18  3:55                       ` Adam Porter
2020-12-23 21:07                         ` Juri Linkov
2020-12-24 11:26                           ` Adam Porter
2020-12-14  9:14         ` Adam Porter
2020-12-14 19:33           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czzaxxr8.fsf@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.