From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: William C Doughty III Newsgroups: gmane.emacs.bugs Subject: bug#45611: 28.0.50; xterm.c compile anomaly and link failure Date: Sat, 02 Jan 2021 11:49:08 -0500 Message-ID: <87czyn473v.fsf@optonline.net> References: <87o8i74jjc.fsf@optonline.net> <83mtxre6y3.fsf@gnu.org> <87h7nz4c0c.fsf@optonline.net> <83im8fe2es.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45611@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 02 19:22:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvlXh-0001XC-Kk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jan 2021 19:22:21 +0100 Original-Received: from localhost ([::1]:45262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvlXg-0008I9-Kd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jan 2021 13:22:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvlXO-0008HZ-J4 for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2021 13:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvlXO-0005TM-Bw for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2021 13:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvlXO-0006A9-8o for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2021 13:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: William C Doughty III Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jan 2021 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45611 X-GNU-PR-Package: emacs Original-Received: via spool by 45611-submit@debbugs.gnu.org id=B45611.160961171623662 (code B ref 45611); Sat, 02 Jan 2021 18:22:02 +0000 Original-Received: (at 45611) by debbugs.gnu.org; 2 Jan 2021 18:21:56 +0000 Original-Received: from localhost ([127.0.0.1]:60830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvlXH-00069Y-LD for submit@debbugs.gnu.org; Sat, 02 Jan 2021 13:21:56 -0500 Original-Received: from mta7.srv.hcvlny.cv.net ([167.206.4.202]:7853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvk5x-0003oj-41 for 45611@debbugs.gnu.org; Sat, 02 Jan 2021 11:49:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=optonline.net; s=dkim-001; t=1609606171; bh=cwmbAr4K1+44vegkB/18hNcEH/lx1/oMmJWqD3lAitg=; h=From:To:Subject:Date:Message-ID; b=ayLtcjALebLlya7qkG4KeWyK0Dr/SIfw/5DZLMEu27gdbcrEvwGKZ8+OAjhaXL2uq Wg+xxw8QUACDHL2YM00mgTg1Z/KrQ1I05ZO/yAbzFghOeweoQOY0ra4m6SKguLKrtT HdcGaNSkWMsLCtILNj5O1+UGURM5PW6Ww+/unA+hhxecw7JwhpOpSNjwWXeZNZJ7s/ XK20+CYs10Q9TTxBetqQXOUCWzH6upmGh5NqfQ9DXCYTN49F6jOw1P5cek/EzixN02 tVg2qsCAowHK0P4JVzJFv+3yQukoLPEZ8LfbvmOQ9J5/LuvF2Sq5h1aICpdJxybFww yRy8DonUOAwDw== Authentication-Results: mta3.srv.hcvlny.cv.net smtp.user=n2ocm; auth=pass (LOGIN) X-Content-Analysis: v=2.3 cv=VL9GY+HX c=1 sm=1 tr=0 a=/F5LWvccb0vVqFBexeKYAA==:117 a=/F5LWvccb0vVqFBexeKYAA==:17 a=IkcTkHD0fZMA:10 a=mDV3o1hIAAAA:8 a=xRfjoxBpAAAA:8 a=JYMjF6dCIF6zf5eQekIA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=4plUlNce3Gdv3FjnGo9M:22 Original-Received: from [24.188.211.146] ([24.188.211.146:54822] helo=LAPTOP-D3MMH7MQ.optonline.net) by mta3.srv.hcvlny.cv.net (envelope-from ) (ecelerity 3.6.9.48312 r(Core:3.6.9.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 5B/3D-00463-B14A0FF5; Sat, 02 Jan 2021 11:49:31 -0500 In-Reply-To: <83im8fe2es.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Jan 2021 18:20:27 +0200") X-Mailman-Approved-At: Sat, 02 Jan 2021 13:21:54 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197209 Archived-At: Eli Zaretskii writes: > [Please use Reply All to keep the bug address on the CC list.] > >> From: William C Doughty III >> Date: Sat, 02 Jan 2021 10:03:15 -0500 >>=20 >> >> Needed to manually set HAVE_XRENDER and add -lXrender >> >> to src/Makefile, after this the make compiles xterm.c >> >> cleanly and the link for temacs succeeds. >> > >> > Please show the part of config.log where it tests for Xrender >> > availability. >> > >> > Thanks. >>=20 >> >From the config.log , at least I think that's the section. >>=20 >> | #define USE_XIM 1 >> | #define XRegisterIMInstantiateCallback_arg6 XPointer >> | /* end confdefs.h. */ >> | #include >> | #include >> |=20 >> | int >> | main () >> | { >> | return !XRenderQueryExtension; >> | ; >> | return 0; >> | } > > Yes, but please show all the rest, starting with "checking for > XRenderQueryExtension in -lXrender" and ending with "$? =3D ..." after > the test. The test program is printed _after_ the stuff I want to > see, in particular the error messages that failed the compilation of > the test program. > >> configure:14699: checking for cairo >=3D 1.8.0 >> configure:14706: $PKG_CONFIG --exists --print-errors "$CAIRO_MODULE" >> configure:14709: $? =3D 0 >> configure:14723: $PKG_CONFIG --exists --print-errors "$CAIRO_MODULE" >> configure:14726: $? =3D 0 >> configure:14764: result > > This the next test, so it is not relevant. > >> The below if from the last time I tried a a compile from >> master. This is on a Fedora 32 system after : > > Strange, it looks like the test for XRender was not done at all... > On my system that test is between these two: > >> checking for inotify_init1... yes >> checking for cairo >=3D 1.8.0... yes > > It says: > > checking for XRenderQueryExtension in -lXrender... yes > > Why isn't that test being run on your system? Your guess is as good ( or better ) than mine. I'm not too familiar with how these scripts work. And as far as config.log the check for XRenderQueryExyension in -lXrender it's not there at all. I just checked the version of autoconf. It's 2.69. So either This commit borked the config setup. Or somthing else is going on. As I said backing out this commit make the config and compile happy. BTW. this commit was the last I saw that affected configure.ac Commit follows: Author: Paul Eggert AuthorDate: Fri Jan 1 12:52:55 2021 -0800 Commit: Paul Eggert CommitDate: Fri Jan 1 12:58:17 2021 -0800 Parent: ac8875173a New file scratch_buffer_dupfree.c Merged: emacs-27 Contained: master Follows: emacs-27.1 (4105) Port to Solaris 10 * configure.ac: Instead of AC_CHECK_HEADER, use AC_COMPILE_IFELSE with X11/Intrinsic.h when checking for X11/extensions/Xrender.h. This suppresses a bogus "report a bug to bug-gnu-emacs" diagnostic from 'configure' in Solaris 10. (SETUP_SLAVE_PTY): Adjust to recent renaming of forkin to std_in in callproc.c. Needed on Solaris and Unixware. * lib-src/Makefile.in (LIB_GETRANDOM, LIBS_ETAGS): New vars, needed because on Solaris 10 the Gnulib tempname module now needs the -lrt library for clock_gettime. Throw in the LIB_GETRANDOM stuff too while we=E2=80=99re at it; from getrandom.m4 it seems to be needed for MingW. (LIBS_MOVE, etags_libs): Use them. * src/callproc.c [SETUP_SLAVE_PTY]: Include sys/stream.h and sys/stropts.h, for SETUP_SLAVE_PTY=E2=80=99s definiens. * src/process.c [NEED_BSDTTY]: Don=E2=80=99t include bsdtty.h; hasn=E2=80= =99t been needed in years. [USG5_4]: Don=E2=80=99t include sys/stream.h or sys/stropts.h; these directives havbe been moved to callproc.c because the only use of SETUP_SLAVE_PTY is there now. 4 files changed, 19 insertions(+), 13 deletions(-) configure.ac | 9 +++++++-- lib-src/Makefile.in | 9 +++++++-- src/callproc.c | 5 +++++ src/process.c | 9 --------- modified configure.ac @@ -3291,7 +3291,12 @@ AC_DEFUN # Check for XRender HAVE_XRENDER=3Dno if test "${HAVE_X11}" =3D "yes"; then - AC_CHECK_HEADER([X11/extensions/Xrender.h], + AC_COMPILE_IFELSE( + [AC_LANG_PROGRAM( + [[#include + #include + ]], + [[return !XRenderQueryExtension;]])], [AC_CHECK_LIB([Xrender], [XRenderQueryExtension], [HAVE_XRENDER=3Dyes]= )]) if test $HAVE_XRENDER =3D yes; then XRENDER_LIBS=3D"-lXrender" @@ -4926,7 +4931,7 @@ AC_DEFUN AC_DEFINE(FIRST_PTY_LETTER, ['z']) AC_DEFINE(PTY_NAME_SPRINTF, [strcpy (pty_name, "/dev/ptmx");]) dnl Push various streams modules onto a PTY channel. Used in process.= c. - AC_DEFINE(SETUP_SLAVE_PTY, [if (ioctl (forkin, I_PUSH, "ptem") =3D=3D = -1) fatal ("ioctl I_PUSH ptem"); if (ioctl (forkin, I_PUSH, "ldterm") =3D= =3D -1) fatal ("ioctl I_PUSH ldterm"); if (ioctl (forkin, I_PUSH, "ttcompat= ") =3D=3D -1) fatal ("ioctl I_PUSH ttcompat");], [How to set up a slave PTY= , if needed.]) + AC_DEFINE(SETUP_SLAVE_PTY, [if (ioctl (std_in, I_PUSH, "ptem") =3D=3D = -1) fatal ("ioctl I_PUSH ptem"); if (ioctl (std_in, I_PUSH, "ldterm") =3D= =3D -1) fatal ("ioctl I_PUSH ldterm"); if (ioctl (std_in, I_PUSH, "ttcompat= ") =3D=3D -1) fatal ("ioctl I_PUSH ttcompat");], [How to set up a slave PTY= , if needed.]) ;; esac =20 <#secure method=3Dpgpmime mode=3Dsign>