From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#46609: Fix shell password prompt in minibuffer (bug 43302) Date: Thu, 18 Feb 2021 12:50:47 +0100 Message-ID: <87czwxzjag.fsf@igel.home> References: <87czwytbxq.fsf@protonmail.com> <8735xty50f.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39310"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.91 (gnu/linux) Cc: Ryan Prior , 46609@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 12:52:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lChr8-000A6q-Bh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 12:52:26 +0100 Original-Received: from localhost ([::1]:33282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lChr7-0007Ix-B7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 06:52:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lChpm-0006gP-5E for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 06:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lChpl-0004Kz-TK for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 06:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lChpl-0008M7-S9 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 06:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 11:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 46609-submit@debbugs.gnu.org id=B46609.161364905232103 (code B ref 46609); Thu, 18 Feb 2021 11:51:01 +0000 Original-Received: (at 46609) by debbugs.gnu.org; 18 Feb 2021 11:50:52 +0000 Original-Received: from localhost ([127.0.0.1]:46262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lChpb-0008Lj-Qq for submit@debbugs.gnu.org; Thu, 18 Feb 2021 06:50:52 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]:57332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lChpa-0008Lb-K3 for 46609@debbugs.gnu.org; Thu, 18 Feb 2021 06:50:51 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DhChT0qm5z1qs11; Thu, 18 Feb 2021 12:50:48 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DhChS67yCz1sP7R; Thu, 18 Feb 2021 12:50:48 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id osG4DTpTnXMC; Thu, 18 Feb 2021 12:50:48 +0100 (CET) X-Auth-Info: M6whECs1G0CGFJ3F+kmy2sbKk93f6C+7AfUaJATMgFVqck2vuuTRbmPs+W0rwyaw Original-Received: from igel.home (ppp-46-244-187-212.dynamic.mnet-online.de [46.244.187.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 18 Feb 2021 12:50:48 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 94B3C2C3200; Thu, 18 Feb 2021 12:50:47 +0100 (CET) X-Yow: I hope you millionaires are having fun! I just invested half your life savings in yeast!! In-Reply-To: <8735xty50f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 18 Feb 2021 12:44:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200245 Archived-At: On Feb 18 2021, Lars Ingebrigtsen wrote: > Ryan Prior writes: > >> The current comint-password-prompt-regexp does not tolerate newlines at >> the end of the prompt, so a string like "Password:\n" will not be >> recognized as a password prompt in shell-mode. Before Emacs 27 >> (74277b0e881) newlines were tolerated here, so this is a regression, and >> as a result I would sometimes echo my password in plain text where >> previously it would be hidden. > > Thanks; applied to Emacs 27 with one change: > >> + (when (string-match "[\n]+$" string) >> + (setq string (replace-match "" t t string))) > > This should probably be "\n+\\'", because we only want to remove > newlines from the end of the string, and not newlines from the middle of > the string, presumably? ("$" means "match end of line", not "match end > of string".) The preceding line should probably use "\\`" as well. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."