Re: master a283996: Add command for customizing current newsticker feed

Re: master a283996: Add command for customizing current newsticker feed

[Basil L. Contovounesios]

ulf.jasper@web.de (Ulf Jasper) writes:

> branch: master
> commit a283996fc728e249816d3bd43a6da1f3c0eab837
> Author: Ulf Jasper <ulf.jasper@web.de>
> Commit: Ulf Jasper <ulf.jasper@web.de>
>
>     Add command for customizing current newsticker feed

[...]

> +(defun newsticker-customize-feed (feed-name)
> +  "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME."
> +  (interactive
> +   (list (completing-read "Name of feed or group to edit: "
> +                          (append (mapcar #'car newsticker-url-list)

FWIW, completing-read also accepts alists with string/symbol keys
directly.

> +                                  nil t feed-name))))

This call to (append (..) nil t feed-name) will signal an error.

> +  (customize-variable 'newsticker-url-list)
> +  (delete-other-windows)

Doesn't this interfere with the user's display-buffer-alist
customisations?  customize-variable uses pop-to-buffer, so in
theory no further window adjustment should be necessary.

> +  (when (re-search-forward (concat "Label: " feed-name) nil t)

Should this be 'search-forward' instead?

Thanks,

-- 
Basil

Re: master a283996: Add command for customizing current newsticker feed

[Ulf Jasper]

Am 23.02.2021 um 17:05 (+0000) schrieb Basil L. Contovounesios:
> This call to (append (..) nil t feed-name) will signal an error.

This is fixed now.

>> +  (customize-variable 'newsticker-url-list)
>> +  (delete-other-windows)
>
> Doesn't this interfere with the user's display-buffer-alist
> customisations?  customize-variable uses pop-to-buffer, so in
> theory no further window adjustment should be necessary.

Removed call to 'delete-other-windows'.

>> +  (when (re-search-forward (concat "Label: " feed-name) nil t)
>
> Should this be 'search-forward' instead?

Changed.

Thanks!
ulf

Re: master a283996: Add command for customizing current newsticker feed

[Eli Zaretskii]

The new code installed by this change triggers a warning:

  In newsticker-customize-feed:
  net/newst-backend.el:656:46: Warning: reference to free variable `feed-name'

And this code looks strange to me:

  +(defun newsticker-customize-feed (feed-name)
  +  "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME."
  +  (interactive
  +   (list (completing-read "Name of feed or group to edit: "
  +                          (append (mapcar #'car newsticker-url-list)
  +                                  nil t feed-name))))

Look at the arguments of 'append': what is that supposed to do?

And how can the 'interactive' form reference the argument list that
it's supposed to generate?  What am I missing?

Thanks.

Re: master a283996: Add command for customizing current newsticker feed

[Ulf Jasper]

Am 23.02.2021 um 19:35 (+0200) schrieb Eli Zaretskii:
> And how can the 'interactive' form reference the argument list that
> it's supposed to generate?  What am I missing?

Thanks for pointing out.  This is fixed now.

ulf