From: Kyle Meyer <kyle@kyleam.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Sat, 01 May 2021 01:08:05 -0400 [thread overview]
Message-ID: <87czubrqh6.fsf@kyleam.com> (raw)
In-Reply-To: <87y2d2mqik.fsf@localhost>
Ihor Radchenko writes:
> I was recently testing Org mode using old Emacs versions. Running make
> on master fails with the following errors and warnings:
Here are a few notes on ones present in maint that I've glanced at.
> Compiling /home/yantar92/Git/org-mode/lisp/ol-eww.el...
>
> In org-eww-store-link:
> ol-eww.el:76:36:Warning: reference to free variable `eww-data'
>
> In end of data:
> ol-eww.el:182:1:Warning: the function `eww-current-url' is not known to be
> defined.
These are guarded by version checks. Ideally the compatibility kludges
would be done in a way to avoid the warnings (e.g., with boundp/fboundp
guards) or at least wrapped in with-no-warnings, though harmless
warnings on Emacs 24 don't really matter too much at this point.
> In end of data:
> org-agenda.el:10851:1:Warning: the following functions are not known to be
> defined: funcall-interactively, window-font-width
Adding a compatibility function for window-font-width is tricky. We
can't just add something like below to org-compat because font-info (C
code) wasn't added until Emacs 25.
(if (fboundp 'window-font-width)
(defalias 'org-window-font-width 'window-font-width)
(defun org-window-font-width (&optional window face)
(with-selected-window (window-normalize-window window t)
(if (display-multi-font-p)
(let* ((face (if face face 'default))
(info (font-info (face-font face)))
(width (aref info 11)))
(if (> width 0)
width
(aref info 10)))
(frame-char-width)))))
> In org-display-inline-images:
> org.el:16554:57:Warning: reference to free variable `image-map'
This warning is now gone (df84100d0), though functionally it was fine
due to a version check.
> In end of data:
> org.el:21292:1:Warning: the function `make-process' is not known to be
> defined.
This should be addressed by 869b7a21b.
next prev parent reply other threads:[~2021-05-01 5:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 14:29 Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
2021-04-28 14:48 ` Timothy
2021-04-28 15:31 ` Ihor Radchenko
2021-04-28 15:47 ` Timothy
2021-04-30 7:26 ` Bastien
2021-05-01 13:57 ` Ihor Radchenko
2021-05-01 14:33 ` Bastien
2021-04-28 21:21 ` Robert Horn
2021-04-29 9:10 ` Colin Baxter
2021-04-29 14:46 ` Robert Horn
2021-04-29 15:36 ` Colin Baxter
2021-04-29 15:51 ` Timothy
2021-04-29 16:04 ` Colin Baxter
2021-04-29 19:42 ` Tim Cross
2021-04-30 7:25 ` Bastien
2021-09-28 5:33 ` Bastien
2021-09-28 17:06 ` Bug: Org mode fails to compile using Emacs 24.5-r10 Max Nikulin
2021-09-28 20:36 ` Samuel Wales
2021-09-28 23:57 ` Tim Cross
2021-09-29 6:59 ` Bastien
2021-09-29 6:58 ` Bastien
2021-09-28 23:34 ` Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)] Tim Cross
2021-09-29 6:45 ` Bastien
2021-05-01 5:08 ` Kyle Meyer [this message]
2021-05-01 13:49 ` Ihor Radchenko
2021-05-01 14:35 ` Kyle Meyer
2021-05-01 20:13 ` Kyle Meyer
2021-05-01 20:27 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czubrqh6.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.