From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Wed, 05 May 2021 10:11:03 +0200 Message-ID: <87czu58uso.fsf@gnus.org> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32393"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 05 10:12:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leCeB-0008Iq-EZ for ged-emacs-devel@m.gmane-mx.org; Wed, 05 May 2021 10:12:43 +0200 Original-Received: from localhost ([::1]:37134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leCeA-0003sN-Fv for ged-emacs-devel@m.gmane-mx.org; Wed, 05 May 2021 04:12:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leCcj-0002Xk-4F for emacs-devel@gnu.org; Wed, 05 May 2021 04:11:13 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:51260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leCch-0005Q0-0D for emacs-devel@gnu.org; Wed, 05 May 2021 04:11:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k0DJFEzU7LdIhTE7EBjXndqnDGpzPubpOUXknFx/GKw=; b=ZUkYSZvTFS9+vloH7Gmwp7sbOX Vl8ms3bSJuHhoU+h2l2fL0QW50ZDeO63iXz0WDGKplLURh8NdC3zxACR6PrYnBEuWFeILTuiMMRwc Xvup3YcjINA0RvQeLSpMGI7ql97+2HiF6Ht2tA5U7xTB+kM0RkTELfRhWzNp5HlMQWzM=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leCca-0006Xc-G6; Wed, 05 May 2021 10:11:06 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX58u7Irq91bYUk FBb///9XP3FsAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFAggqJLXPHisAAAF/SURBVDjLtZNrcsUg CIXBbEB0A4IbiLL/vRXQJG1v+rMkM3H4wsujAP9p9O4uxJRf/NiJkd8CZmUs7TN/V2Uq09eekGit kETV/MoM+ADyR4SK6txlLiBEVIpFqexeokNCFRZxv94RBlAsh3YNG1EbN6h624wNuID/PTe5QHMQ OXauPcYD2s63apcH5HqnQptX+COCvMJ3gH2SwRjW/BeYoQUamOJGvOaQrVH3iAAxB85bLqtBniwA g166VAVeZIHe9kbXVfwBA/BbhJsnFuhXkaiBD6iaMdY+oMm5dpcEirZoGAOY8Y7IesYhSD55kdiQ BfpAD+kOzC2cNzjUVy4x+En1aEsmOScT2+fu16hojw2araqYwrNsUHuTpLNrW2I0qCEt1Hz2g+dM S3EbMzlAA0Mq0AnjMFFWk1Z6gSPjwJHsgC6xYjsqjJ70tBqQ2Bu775G9uXARj+/n+yXE8uMKRg/r +3pr8f7t9x3c+IMsB+EfIONrW6YbfBLM4noifAGZ+kMHzQ97zgAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMS0wNS0wMlQwODo0MjozNSswMDowMJAG8n0AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDUt MDJUMDg6NDI6MzUrMDA6MDDhW0rBAAAAAElFTkSuQmCC X-Now-Playing: Nico's _Do Or Die_: "Heroes" In-Reply-To: <87mtt9sqh4.fsf@red-bean.com> (Karl Fogel's message of "Wed, 05 May 2021 00:24:07 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268900 Archived-At: Karl Fogel writes: > Revised patch attached, with the option now defaulting to nil (i.e., > to the old behavior) as per discussion. Review/comments welcome. > > Lars, you wrote this regarding v1 of this patch: > >> ...the first line [of the doc string] should be a complete sentence. > > It actually was a complete sentence even in v1, but I think I know > what you meant. However, the "Non-nil means..." phrasing is found > throughout Emacs -- I counted over 1000 places with this quick check: What I meant was that the first line should be a complete sentence. :-) > +(defcustom bookmark-menu-confirm-deletion nil > + "Non-nil means prompt for confirmation when executing the deletion > +of bookmarks marked for deletion in a bookmark menu buffer; nil > +means don't prompt for confirmation." This doc string is three lines long, and the first line isn't a complete sentence -- but it should be. In any case, as I said -- I don't think adding this user option makes a lot of sense. Instead bookmark should implement "undo" functionality. And adding the option, but defaulting to nil, makes even less sense -- nobody is going to discover this option unless it defaults to t. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no