From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 07/15] Add BVAR_OR_DEFAULT macro as a stub Date: Fri, 07 May 2021 09:24:02 -0400 Message-ID: <87czu2r825.fsf@catern.com> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-8-sbaugh@catern.com> <837dkaddbc.fsf@gnu.org> <87k0oar8x5.fsf@catern.com> <83pmy2bsci.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 15:30:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf0Ya-0007p5-Fw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 15:30:16 +0200 Original-Received: from localhost ([::1]:36382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0YZ-0006Tb-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 09:30:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf0TW-00005r-8m for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf0TW-0000WS-1A for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf0TV-0006lu-UU for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 13:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039384526009 (code B ref 48264); Fri, 07 May 2021 13:25:01 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 13:24:05 +0000 Original-Received: from localhost ([127.0.0.1]:43885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0Sb-0006lR-KE for submit@debbugs.gnu.org; Fri, 07 May 2021 09:24:05 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:60388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0SZ-0006lL-TL for 48264@debbugs.gnu.org; Fri, 07 May 2021 09:24:04 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1620393843; bh=Wn8xoMppA6gPwiu9tL4qbMJMVW1zVHygcYvZ16khO6o=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=XXuLWmAjl3dMVnfNO0UqIwOlXvhLdYiko+jEiZLQ3vlgk/nmE3RV2J+zibmD0JP2E oMPhEeYlNUWZO4CP3u8vfrjH6C1TSCj8MH3OURGzYNN52SjASIDYYy7c9eOGzaXJJZ nQlYTnsoX5Oi+zqnSS3s8gt2d0Ua0jIG47+h3u6U= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 731AE2E9748; Fri, 7 May 2021 13:24:03 +0000 (UTC) In-Reply-To: <83pmy2bsci.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205936 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: 48264@debbugs.gnu.org >> Date: Fri, 07 May 2021 09:05:26 -0400 >> >> >> +#define BVAR_OR_DEFAULT(buf, field) BVAR (buf, field) >> > >> > What am I missing here? >> >> The commit message is accurate - we indeed use BVAR for buffer variables >> without a default, and BVAR_OR_DEFAULT for buffer variables with a >> default. >> >> It's just that in this commit, those two behave identically. The >> immediate next commit makes them different. > > I thought I asked you not to make changes that are overwritten by > subsequent patches in the series, as it makes review harder. It also > makes the supposedly separate changes in the set not really separate, > because one cannot revert one of them and still have a functional > Emacs. Sure, I can merge the two changes together, I'll do that for the next revision of the series. Just felt this was easier to review.