From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: pillule Newsgroups: gmane.emacs.bugs Subject: bug#48493: 28.0.50; quit-window doesn't work Date: Mon, 24 May 2021 14:53:21 +0000 Message-ID: <87cztg41zy.fsf@host.localdomain> References: <87h7j0wwkf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9541"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pillule , Sujith Manoharan , 48493@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 24 16:54:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llByE-0002FZ-JT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 May 2021 16:54:18 +0200 Original-Received: from localhost ([::1]:34616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llByD-0007PJ-Mp for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 May 2021 10:54:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llBxy-0007NP-P2 for bug-gnu-emacs@gnu.org; Mon, 24 May 2021 10:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llBxy-0002K5-Gr for bug-gnu-emacs@gnu.org; Mon, 24 May 2021 10:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llBxy-0005bG-GK for bug-gnu-emacs@gnu.org; Mon, 24 May 2021 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 May 2021 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 48493-submit@debbugs.gnu.org id=B48493.162186802321500 (code B ref 48493); Mon, 24 May 2021 14:54:02 +0000 Original-Received: (at 48493) by debbugs.gnu.org; 24 May 2021 14:53:43 +0000 Original-Received: from localhost ([127.0.0.1]:43661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llBxf-0005ah-Bw for submit@debbugs.gnu.org; Mon, 24 May 2021 10:53:43 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:43726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llBxb-0005aR-5Z for 48493@debbugs.gnu.org; Mon, 24 May 2021 10:53:41 -0400 Original-Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FpgFS67hQzDqh4; Mon, 24 May 2021 07:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1621868012; bh=fQazK8MuBjenDIQVz1GkR6WlqrTkjFz2E3rV/fvnBII=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=biAohOBGroXrAJNiqnOJFBwcE/dheO6EVPy5/ja3qUNP/Ra978h5yXOoNVym+Cjjc qKn8Sq3Tu5E1frugkBipXY3Va/1xTMtsYY6usv/dos42VzEFrUH0s1wOndsX/hGvP7 ruZCgLo4PCuXcqAajWAcfGDHufGOixFO5V3anFVU= X-Riseup-User-ID: 766A3E7FA247874B0C45CC0D64B749CB2B3383641E6E3204DA34F5C84A6517B5 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FpgFQ4LTyz5vNY; Mon, 24 May 2021 07:53:30 -0700 (PDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207127 Archived-At: martin rudalics writes: > > Looks like commit 0a681590268a4039f95a5a919b6b6d4f4e880d4c is > > the problem. Sorry about that. > Right. Can you try the attached patch? pillule, please also > have a > look into this. I think there is still edges cases : with emacs -Q ;; set some rules (setq display-buffer-alist '(("\\*\\(Backtrace\\)\\*" (display-buffer-in-side-window) (window-height . 0.2) (side . bottom)) ("\\*\\(Messages\\)\\*" (display-buffer-in-side-window) (window-height . 0.2) (side . bottom)))) ;; display the *Messages* buffer (view-echo-area-messages) ;; trigger a logical error to display the *Backtrace* buffer (> vim emacs) ;; trigger a quit-restore-window by calling kill-buffer in a dedicated window (kill-buffer (get-buffer "*Backtrace*")) ;; the dedicated property has been cleaned from the window, ;; yet *Messages* is displayed in place of this window ! (kill-buffer (get-buffer "*Messages*")) ;; calling kill-buffer in a non-dedicated window, ;; does not trigger quit-restore-window anymore ;; resulting in an undesirable buffer being displayed in place. What is the desired behavior of a dedicated window here ? Must *Messages* be displayed after we killed *Backtrace* in the first place ? I am suspecting that the locale value of `kill-buffer-hook' in *Backtrace* is interfering with this test but I have difficulties to find its human readable form. --