From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Tue, 13 Jul 2021 18:27:32 +0200 Message-ID: <87czrmrxfv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49534@debbugs.gnu.org, "Richard M. Stallman" To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 13 18:28:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3LGV-0000Gd-R9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 18:28:11 +0200 Original-Received: from localhost ([::1]:44788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3LGU-0007nu-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 12:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3LGL-0007hG-UM for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 12:28:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3LGL-0004Pw-MP for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 12:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3LGL-0003Mo-KL for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 12:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jul 2021 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.162619366712918 (code B ref 49534); Tue, 13 Jul 2021 16:28:01 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 13 Jul 2021 16:27:47 +0000 Original-Received: from localhost ([127.0.0.1]:41646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3LG6-0003MI-OC for submit@debbugs.gnu.org; Tue, 13 Jul 2021 12:27:46 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3LG2-0003M3-Mv for 49534@debbugs.gnu.org; Tue, 13 Jul 2021 12:27:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vopbeE9A7lfEwD51mAoj33I2WakTH5eLVTcV3AlnT5Q=; b=c03M7l9TzDP4K4SMJ7xv7PKoWm IFtL21gTV2QnJQ+YUmBGJlLzjTNalfIlB4wEdGqr9MFtRrzbnTcoAJKVyUZzyhXGQl5Ft14PdeR/n dXoW2KOEuq4Oooe7TlgP6OcifO8xB9GN+AgIMumr/WrUVhOxw9QW5R/Rh7KkAyicANU8=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3LFt-0002D8-4K; Tue, 13 Jul 2021 18:27:35 +0200 X-Now-Playing: King Crimson's _The Complete 1969 Recordings (17): Sessions 5_: "Epitaph Takes 5 to 11" In-Reply-To: (Drew Adams's message of "Mon, 12 Jul 2021 14:34:29 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209850 Archived-At: Drew Adams writes: > That won't work. Isearch is unnecessarily restrictive because of this > test in `isearch-search', which if non-nil prevents invoking > `isearch-filter-predicate'. > > (= (match-beginning 0) (match-end 0)) The code is: (while retry (setq isearch-success (isearch-search-string isearch-string nil t)) ;; Clear RETRY unless the search predicate says ;; to skip this search hit. (if (or (not isearch-success) (bobp) (eobp) (= (match-beginning 0) (match-end 0)) (funcall isearch-filter-predicate (match-beginning 0) (match-end 0))) (setq retry nil))) I've tried following the logic here, but I'm not sure why we never retry if the match is zero length. It looks like this was introduced here: commit 86bfaffe409c6f7398bcf2144fa8d9f436bd4002 Author: Richard M. Stallman AuthorDate: Mon Feb 10 09:41:31 1997 +0000 (isearch-search): Refuse to match invisible text. (isearch-range-invisible): New function. (search-invisible): New user option. And, indeed, the default predicate doesn't match on invisible text... but I'm not sure why it's also testing the length of the match. (The default predicate also checks this, so removing the test seems to produce identical results by default.) So I've added Richard to the CCs -- Richard, you don't happen to recall the meaning of that apparently duplicated test in a patch that's only 24 years old? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no