From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49626: Why mouse-1 is not allowed on button links? Date: Mon, 19 Jul 2021 01:38:13 +0300 Organization: LINKOV.NET Message-ID: <87czrfi6y2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3974"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) To: 49626@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 00:40:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5FSH-0000sh-St for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 00:40:13 +0200 Original-Received: from localhost ([::1]:51886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5FSG-0001pa-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jul 2021 18:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5FS6-0001pC-Bh for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 18:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5FS6-0007f0-17 for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 18:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5FS5-0002mw-VQ for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 18:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jul 2021 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49626 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162664799410697 (code B ref -1); Sun, 18 Jul 2021 22:40:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jul 2021 22:39:54 +0000 Original-Received: from localhost ([127.0.0.1]:57567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5FRx-0002mT-Os for submit@debbugs.gnu.org; Sun, 18 Jul 2021 18:39:53 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5FRu-0002m8-Eu for submit@debbugs.gnu.org; Sun, 18 Jul 2021 18:39:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5FRu-0001p3-3U for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 18:39:50 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:42305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5FRs-0007Uo-83 for bug-gnu-emacs@gnu.org; Sun, 18 Jul 2021 18:39:49 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id CB4BF100004 for ; Sun, 18 Jul 2021 22:39:44 +0000 (UTC) Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210223 Archived-At: Tried to click mouse-1 on the button links in the 'dictionary' buffers (from the built-in package lisp/net/dictionary.el), but it does nothing, unlike mouse-2. Should this patch be applied? I'm asking because I'm not sure about its side effects to other packages. diff --git a/lisp/button.el b/lisp/button.el index 69d70540c0..74dfb5d541 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -61,6 +61,7 @@ button-map ;; might get converted to ^M when building loaddefs.el (define-key map [(control ?m)] 'push-button) (define-key map [mouse-2] 'push-button) + (define-key map [follow-link] 'mouse-face) ;; FIXME: You'd think that for keymaps coming from text-properties on the ;; mode-line or header-line, the `mode-line' or `header-line' prefix ;; shouldn't be necessary!