From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45550: [PATCH] Factor out new function for readability in chartab.c Date: Wed, 21 Jul 2021 14:03:40 +0200 Message-ID: <87czrblvqb.fsf@gnus.org> References: <83k0szhwz1.fsf@gnu.org> <835z4iirgb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45550@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 21 14:05:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6AyZ-0000pp-DH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 14:05:23 +0200 Original-Received: from localhost ([::1]:35088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6AyY-0001yS-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 08:05:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6AyE-0001i3-P7 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 08:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6AyE-0007ZK-H8 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 08:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6AyE-0002Cs-BC for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 08:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45550 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45550-submit@debbugs.gnu.org id=B45550.16268690478409 (code B ref 45550); Wed, 21 Jul 2021 12:05:02 +0000 Original-Received: (at 45550) by debbugs.gnu.org; 21 Jul 2021 12:04:07 +0000 Original-Received: from localhost ([127.0.0.1]:36325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Ax5-0002Ap-Tu for submit@debbugs.gnu.org; Wed, 21 Jul 2021 08:04:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Ax3-0002AV-W5 for 45550@debbugs.gnu.org; Wed, 21 Jul 2021 08:03:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5pAFEiFEtOD2Y15cn1mNy5At+SeCeotINdLJ+Vijr94=; b=YkZOwyJm3FLh4XPytVV3OPSGYX uKic1YhY4BYBsAddxCjrVDq8376Ql6I9PN/h+P8VriLNg9/3vjIiciGDqtI/QU7fw0kPfNGvogPOD FTxrniUhFrbCEfhDk9JfZ2e5qIa+w5p4yoHJ3ZrNtFRsYbpAy2Dp/Rwk2tSPm220QHgY=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Awu-0006F9-QH; Wed, 21 Jul 2021 14:03:43 +0200 X-Now-Playing: Vert's _Broken Breakbeat Bebop_: "Slack Chair Puller" In-Reply-To: <835z4iirgb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Dec 2020 05:29:08 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210420 Archived-At: Eli Zaretskii writes: >> > Please make this a macro, not a function. The code you are factoring >> > out is called in the innermost loops of the display engine, in bidi.c, >> > so it must be as fast as possible, even in an unoptimized build, where >> > static functions aren't inlined. >> >> Would it be acceptable to use our INLINE macro here instead? > > I'd prefer a simple macro. I can never remember the exact semantics > of INLINE this week. I've applied Stefan's patch (with the "static inline" tweak, which we use other places in Emacs, too) because patches bit-rot when they get too old. If it turns out to be a performance issue, then the inline function can be rewritten as a macro. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no