From: Juri Linkov <juri@linkov.net>
To: 50038@debbugs.gnu.org
Subject: bug#50038: Permanent shift-select-mode
Date: Fri, 13 Aug 2021 10:04:27 +0300 [thread overview]
Message-ID: <87czqif4y5.fsf@mail.linkov.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
It's very convenient to use a shift-translated key to activate the region,
because e.g. 'S-C-f' requires typing less keys than 'C-SPC C-f'.
But when there is a need to extend the region by typing a navigation key
that is not shift-translated, it abruptly deactivates the region.
The current default behavior was implemented in such unusable way
because "other apps" behave the same way.
So the following patch provides an option for the behavior that is more
convenient than in "other apps":
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: shift-select-mode-permanent.patch --]
[-- Type: text/x-diff, Size: 1393 bytes --]
diff --git a/lisp/simple.el b/lisp/simple.el
index 25a5a166e8..d951570937 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -6649,9 +6649,15 @@ shift-select-mode
by any subsequent point motion key that was not shift-translated, or
by any action that normally deactivates the mark in Transient Mark mode.
+When the value is `permanent', the mark will not be deactivated
+by any subsequent point motion key that was not shift-translated.
+
See `this-command-keys-shift-translated' for the meaning of
shift-translation."
- :type 'boolean
+ :type '(choice (const :tag "Off" nil)
+ (const :tag "Permanent" permanent)
+ (other :tag "On" t))
+ :version "28.1"
:group 'editing-basics)
(defun handle-shift-selection ()
@@ -6669,7 +6675,12 @@ handle-shift-selection
Otherwise, if the region has been activated temporarily,
deactivate it, and restore the variable `transient-mark-mode' to
its earlier value."
- (cond ((and shift-select-mode this-command-keys-shift-translated)
+ (cond ((and (eq shift-select-mode 'permanent)
+ this-command-keys-shift-translated)
+ (unless mark-active
+ (push-mark nil nil t)))
+ ((and shift-select-mode
+ this-command-keys-shift-translated)
(unless (and mark-active
(eq (car-safe transient-mark-mode) 'only))
(setq-local transient-mark-mode
next reply other threads:[~2021-08-13 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 7:04 Juri Linkov [this message]
2021-08-13 12:06 ` bug#50038: Permanent shift-select-mode Lars Ingebrigtsen
2021-08-14 6:37 ` Eli Zaretskii
2021-08-15 8:37 ` Juri Linkov
2021-08-15 9:36 ` Eli Zaretskii
2021-08-15 16:19 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czqif4y5.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=50038@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.