all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Ergus <spacibba@aol.com>
Cc: emacs-devel@gnu.org
Subject: Re: fido-vertical bindings
Date: Tue, 17 Aug 2021 13:08:37 +0100	[thread overview]
Message-ID: <87czqcw9x6.fsf@gmail.com> (raw)
In-Reply-To: <20210817000745.cpnevwj7anmarue2@Ergus> (Ergus's message of "Tue,  17 Aug 2021 02:07:45 +0200")

Ergus <spacibba@aol.com> writes:

> I just tried the new fido-vertical you added.

I added it some time ago, IIRC.  What I've done very recently is make it
enable fido-mode automatically, so that you don't need two foo-mode
calls to get the desired functionality.  So

M-x fido-vertical-mode

is all you need.

> I think there is a small issue very simple to fix. In vertical mode
> either the right/left arrows and C-n/p may be switched with the actual
> up/down and maybe C-r C-s... to have a consistent behavior.

I had a tough time understanding what you meant, but now I think I do
and I just committed the patch after my sig.

If you use fido-vertical-mode, also notice the new goto-first/last stuff
suggested by Simon Lang in bug#49005.

João

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 96b7e0f201..81fc6ff03c 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -624,6 +624,8 @@ icomplete-vertical-mode-minibuffer-map
   (let ((map (make-sparse-keymap)))
     (define-key map (kbd "C-n") 'icomplete-forward-completions)
     (define-key map (kbd "C-p") 'icomplete-backward-completions)
+    (define-key map (kbd "<down>") 'icomplete-forward-completions)
+    (define-key map (kbd "<up>") 'icomplete-backward-completions)
     (define-key map (kbd "M-<") 'icomplete-vertical-goto-first)
     (define-key map (kbd "M->") 'icomplete-vertical-goto-last)
     map)






  reply	other threads:[~2021-08-17 12:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210817000745.cpnevwj7anmarue2.ref@Ergus>
2021-08-17  0:07 ` fido-vertical bindings Ergus
2021-08-17 12:08   ` João Távora [this message]
2021-08-18 12:25     ` Ergus
2021-08-20  2:21       ` Ergus
2021-08-20  9:55         ` João Távora
2021-08-20 11:46           ` Ergus
2021-08-20 15:27             ` João Távora
2021-08-20 15:41             ` [External] : " Drew Adams
2021-08-20 11:51           ` André A. Gomes
2021-08-20 12:51             ` Ergus
2021-08-20 15:42               ` [External] : " Drew Adams
2021-08-20 15:52                 ` Eli Zaretskii
2021-08-20 16:42                   ` Drew Adams
2021-08-21  3:21                     ` Richard Stallman
2021-08-21  5:18                       ` Drew Adams
2021-08-20 15:37             ` João Távora
2021-08-20 15:41             ` [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czqcw9x6.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.