From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48603: 27.2; [PATCH] Quit minibuffers without aborting kmacros Date: Tue, 17 Aug 2021 23:45:15 +0100 Message-ID: <87czqbzo5g.fsf@tcd.ie> References: <86eedx7c0u.fsf@miha-pc> <877djmegh8.fsf@gnus.org> <86r1hu4hws.fsf@miha-pc> <877dhlf9ex.fsf@gnus.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48603@debbugs.gnu.org, miha@kamnitnik.top To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 18 00:46:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mG7qa-0001Yp-JG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Aug 2021 00:46:17 +0200 Original-Received: from localhost ([::1]:50864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mG7qY-00032m-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Aug 2021 18:46:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG7qM-00032a-7O for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 18:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mG7qL-0001GE-Qr for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 18:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mG7qL-00078r-Mj for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 18:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Aug 2021 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48603-submit@debbugs.gnu.org id=B48603.162924032827406 (code B ref 48603); Tue, 17 Aug 2021 22:46:01 +0000 Original-Received: (at 48603) by debbugs.gnu.org; 17 Aug 2021 22:45:28 +0000 Original-Received: from localhost ([127.0.0.1]:54389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG7po-00077y-A3 for submit@debbugs.gnu.org; Tue, 17 Aug 2021 18:45:28 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:43939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG7pk-00077i-As for 48603@debbugs.gnu.org; Tue, 17 Aug 2021 18:45:26 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id k5-20020a05600c1c85b02902e699a4d20cso514832wms.2 for <48603@debbugs.gnu.org>; Tue, 17 Aug 2021 15:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7gK0U4OeWUXJRgIwyZDXuUocarYlrxdcch6L1r5B7r4=; b=CUq1kOREwzMOEgz1/vt1nWUhQBO65zcIbj4XNW4SYcWr5zluLMCBQXWy02H37PS8K7 aTJxFwqJS33Y2+1G4WniF9Qk2ZTGxV9V6SnqLzgwHttDQ+tPog3kAqdma55MOgvsdm1v wSZVW/4IMInsO22crBFRwJ8G5tPy27hNNn5n15xF4mmfPCs8nrBbhfsTC629//wJMx+t FZElMPk0uS4r1HKeYXl++asCS9e8DJB7qi2MZRwwONMk+fE+YRGQZldeMuPQ3w7qy9e/ yazpEN7yeTvj5M3vVcdb0c1nPeVaDK44izBvYKHS34VAS+dJdL/YhDyxR8v+PN+3Mtlx fcDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7gK0U4OeWUXJRgIwyZDXuUocarYlrxdcch6L1r5B7r4=; b=QVL0xjDioWtKfkIQ8O557l1CVjFVRc0FpaJRpNWIdQu5slfW4Ib0QSsvqqAXV1Rh/8 yj+GjCfeZeM200q6l2pI4b19hBEnzuV+LcCefZ+GdDSqWJzsMHhZQFbuikUeYbnEXrhv r/ROUQvHkuDQ3iWTVtdCzdvHO1yxZDktpJu9v9XaKN8MLSTgw19xqN766RO01vQVYBRM yMSdXS0fSSfaz1FQqd1/97jGEDCPnR7Gb0obr8qqVTdO2T8MTB03IPoTdKpYJpMOSTM1 HQm/c/taFeeYx7yGKrhgbSEmgvhBJIE7ln6HL3+/oeggKDJwMN7UbWxugVBJtnEw5+8r LeQw== X-Gm-Message-State: AOAM532zKPLPxUAysTBket626K82949/dpe+CsXlrwRvOjkjEsNjsrxr KeJirsB0sJatWgMVyAeOpoSoLQ== X-Google-Smtp-Source: ABdhPJyiTAEeR/I4x0KalvZgF0scdAez+3wyYILOzOp3MNmMucn1Qq+noBFrYEFAvpDP1uOITPIUUA== X-Received: by 2002:a1c:7419:: with SMTP id p25mr5364285wmc.160.1629240318403; Tue, 17 Aug 2021 15:45:18 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id y15sm3852297wrw.58.2021.08.17.15.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 15:45:17 -0700 (PDT) In-Reply-To: <877dhlf9ex.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 20 Jul 2021 14:37:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212112 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen [2021-07-20 14:37 +0200] wrote: > writes: > >> Good idea, attaching a revised patch (which also adds two NEWS entries.) > > Sorry; I forgot all about this. I've now re-read and tested the patch, > and it seems to work fine for me, so I've pushed it to Emacs 28. Thanks, but given the following file quit.el, which is distilled from the Ivy package's batch-run test suite: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline; filename=quit.el Content-Transfer-Encoding: quoted-printable ;; -*- lexical-binding: t -*- (defconst my-read "\C-ce") (local-set-key my-read (lambda () (interactive) (read-from-minibuffer ""))) (condition-case err (execute-kbd-macro (concat my-read "\C-g")) (t (print err))) --=-=-= Content-Type: text/plain the patch gives rise to the following change in behaviour. Before: $ emacs -Q -batch -l quit.el (quit) $ echo $? 0 After: $ emacs -Q -batch -l quit.el Quit $ echo $? 255 IOW, it's no longer possible to catch the quit around execute-kbd-macro. I tried wrapping it in (catch 'exit ...) as well, but to no avail. Surely it should always be possible to catch a quit condition from Lisp? Thanks, -- Basil --=-=-=--