all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 48603@debbugs.gnu.org, miha@kamnitnik.top
Subject: bug#48603: 27.2; [PATCH] Quit minibuffers without aborting kmacros
Date: Tue, 17 Aug 2021 23:45:15 +0100	[thread overview]
Message-ID: <87czqbzo5g.fsf@tcd.ie> (raw)
In-Reply-To: <877dhlf9ex.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 20 Jul 2021 14:37:42 +0200")

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Lars Ingebrigtsen [2021-07-20 14:37 +0200] wrote:

> <miha@kamnitnik.top> writes:
>
>> Good idea, attaching a revised patch (which also adds two NEWS entries.)
>
> Sorry; I forgot all about this.  I've now re-read and tested the patch,
> and it seems to work fine for me, so I've pushed it to Emacs 28.

Thanks, but given the following file quit.el, which is distilled from
the Ivy package's batch-run test suite:


[-- Attachment #2: quit.el --]
[-- Type: application/emacs-lisp, Size: 226 bytes --]

[-- Attachment #3: Type: text/plain, Size: 426 bytes --]


the patch gives rise to the following change in behaviour.

Before:

  $ emacs -Q -batch -l quit.el

  (quit)
  $ echo $?
  0

After:

  $ emacs -Q -batch -l quit.el
  Quit
  $ echo $?
  255

IOW, it's no longer possible to catch the quit around execute-kbd-macro.
I tried wrapping it in (catch 'exit ...) as well, but to no avail.
Surely it should always be possible to catch a quit condition from Lisp?

Thanks,

-- 
Basil

  reply	other threads:[~2021-08-17 22:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 14:36 bug#48603: 27.2; [PATCH] Quit minibuffers without aborting kmacros miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 19:54 ` Lars Ingebrigtsen
2021-05-25 21:34   ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-20 12:37     ` Lars Ingebrigtsen
2021-08-17 22:45       ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-08-18 14:55         ` Lars Ingebrigtsen
2021-09-01  6:58         ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-01  8:11           ` Lars Ingebrigtsen
2021-09-03 17:53           ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 15:11       ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-08  7:40         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czqbzo5g.fsf@tcd.ie \
    --to=bug-gnu-emacs@gnu.org \
    --cc=48603@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=larsi@gnus.org \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.