From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: 2a73673 Change how thread-first/thread-last indent the first argument Date: Tue, 05 Oct 2021 09:35:19 +0200 Message-ID: <87czoj7wlk.fsf@gnus.org> References: <87ee90vtye.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14898"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 05 09:37:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXf0f-0003iD-Ar for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 09:37:09 +0200 Original-Received: from localhost ([::1]:40658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXf0e-00070T-7T for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 03:37:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXez2-0005Q6-6h for emacs-devel@gnu.org; Tue, 05 Oct 2021 03:35:28 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXez0-0003gg-K3 for emacs-devel@gnu.org; Tue, 05 Oct 2021 03:35:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=APypVjofcJGtvJp4tL5G8VhVr1FoQvze0UtRGsS0leE=; b=d3yjeYpzVAkDDLODWTPSx6nXsB kbNARfMgxgyrVqby8XUI8uopvmkcX3Qa5YzGY9UapMQ0DMdj+Adk8zNw58IqOW/rJ34O4ZWWUJdPv igGe0muNzeZex7gnIHJMOmjr2Aqvu2bjPJzFMqefZoe0t4NyKizoIhkC8ur96gbm8KeQ=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXeyu-0004OW-DH; Tue, 05 Oct 2021 09:35:23 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEX6+fng39/f3t7V 09PCv76zsbDAvr6hnpyTkI+BfXyCf37///932m6CAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+UKBQcG LeH5JXQAAAGDSURBVDjLtVTLSkQxDE0aRl0mLYK4aqe4cJe2jO79grleRJeCC7cOMvgFgp9t5uHo dXyDgYa2IT2np0kBAMTDJ4bv1vwmNLaBYq4Ajcsgx1PzweUCGAa56DEBBbIVDWCQ7RRspIMAQkWG jHw2yEBhEGAU4Y7ekkTDYHBirHQLg5mLZejONUB4pYscNVBNrboMo/5+va12te5RLy+mozqfdPvd fLU/mj3tTTuGh17p7grKRNcgKqejbtYDHk9RD0j9S6Do7W6v+wt2VJrpVer6qPPHw0k3Wc4JecDV BEnwn2aATCDiBUrOulGj+iZKAj4wXvRt+g/QwqsHxGXVLe8d4jrmPURwyV5F2Id2E2rark3cuN8b ZvXQOPL7fOMkiwI6yVQgYnSBh4BLpouB8UdIH1iSKGLeKlc4YHMbCLGqBS8YiqmDP3963hLDOgAp mopoImao9SVw1LRZY7Sqf6X/vUmy+k7WzOCGgdYy9QnUje1DKK5gbhT0VV2GpgsVVj/KV/YMRpIn 9NtjUpgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTAtMDVUMDc6MDY6NDUrMDA6MDCilbMgAAAA JXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEwLTA1VDA3OjA2OjQ1KzAwOjAw08gLnAAAAABJRU5ErkJg gg== X-Now-Playing: Chicks on Speed's _Archive I_: "Youre car will drive you there" In-Reply-To: <87ee90vtye.fsf@alphapapa.net> (Adam Porter's message of "Tue, 05 Oct 2021 01:58:33 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276307 Archived-At: Adam Porter writes: > In this commit, you changed the thread-last macro's indentation from > (indent 1) to (indent 0). The change made the macro indent the way it was documented to indent (in the doc string): "Thread FORMS elements as the first argument of their successor. Example: (thread-first 5 (+ 20) (/ 25) - (+ 40)) > Could this be reverted, please? This change > has two drawbacks: > > 1. The threaded form is no longer indented differently from the other > forms, so it no longer stands out. I don't really have an opinion here -- I can revert the change if that's what people that use the macro wants. It just looked really wrong to me to indent the first element specially, but I don't use these macros in Emacs. I don't think ->> indents the first element specially in Clojure, for instance? (At least I don't remember them doing so.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no