From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems Date: Tue, 15 Feb 2022 21:55:54 +0800 Message-ID: <87czjow7x1.fsf@yahoo.com> References: <83czjqrkew.fsf@gnu.org> <874k52kiu4.fsf@yahoo.com> <837d9yribj.fsf@gnu.org> <87v8xii83e.fsf@yahoo.com> <83r186p1h8.fsf@gnu.org> <878ruehx6n.fsf@yahoo.com> <83h791pmnl.fsf@gnu.org> <87iltheyeu.fsf@yahoo.com> <83wnhwol2o.fsf@gnu.org> <87tud0ybhj.fsf@yahoo.com> <837d9w450e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10063"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 15 15:04:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJyRl-0002Un-QM for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Feb 2022 15:04:49 +0100 Original-Received: from localhost ([::1]:46212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJyRk-0000Ty-Qu for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Feb 2022 09:04:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJyJM-00008e-6c for emacs-devel@gnu.org; Tue, 15 Feb 2022 08:56:08 -0500 Original-Received: from sonic306-21.consmr.mail.ne1.yahoo.com ([66.163.189.83]:42086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJyJH-00021J-2K for emacs-devel@gnu.org; Tue, 15 Feb 2022 08:56:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644933361; bh=JGusj6OXCvJpi/wbU5NqOYUQzQLEEzFxTx1XVms0TWo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=HvLSdvXTnA+7YCngxqwm76isCw06hnvpmLGPlOCSxvDqUe0z5/prgEZMEUK+t8TCe6hf8hH7Q8cDgX5n/BvyKYPR85lxnKUMCK/XznsuVojYtCvVjEEWkdvdEdeVc8ojTuLKM0grS0ezUY5OwfL4dZZub0R9DZM8WdWHsDwn5W4ob7vP04MnC0p3urZj3B5XXJY318dMlL9NTBX2kSFtrTrBLiB28pp1JpsZGSnOLWBLFGDZwII0S0BIygtGECOvRw+B3TVfl627IdeY8qVzQ9fxnPqsJJwuLlf0BiYGtqre5MlMsEcrkDXm3H+OD3txMsuWnggUd5GD68Doc645Gw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644933361; bh=n/AJrl1hndCr6fhxkg7WHxSw9AVJiUdi1X7WHQTefWi=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ZCvc9w7YTKlk3RvRRuh2Ur7bc9UzZc2IEKxfyFkXgVy1FadsF8FntWUW9H6i6ylHiObHEkNDUUwTzK2OSxcistR8sTkxRp6JX3dMPAgUtn1GZX7ZrhexxILFxZ4auK+IywgkDFqmgVCdHye/S0LnAP9a84r8JwrwYPQXK7/+ICbZeVmAleDl47XqZfYxQL4TAviUBkB6hecwb98AO9VLHy+lzn0ShmXqpe6RdgvMSOrpaKpqwrzI1ly0mn2iZYvWCbXEcPLiQqqNN/mXEDKtYJBCR4LmuoYz+RrwfwoZ/bphj9IJi9R8/RyxuN3kzqn47jK1GAXtBds2i4F3TEmkhA== X-YMail-OSG: Rp.IML8VM1nB9XlgzGzTP7_EejMejIIjmduwHIVftwsebnBXseVbXLNEO.AdarA 5Ln3CO7KG_hP82eebi4oL2vSdtabrbuDekjDKiW6z9y4b7GdayPr5ea1j5lXQMiPbNpJMj6nlaRw QK18b4EFWBQgWXd.4Pi9GK8cZdxM6jo25GAVXnzItyfnmH4lB1TaZBqS_RAa2v3RiFlTYz7Sn67M XwSMKapO0XdFGZiKV2ZJCh_zCnQMSh3z6U2UH_BW4FsKDTkmDvIwEO2gaEYQ.79xEifRmnlAb9so 0I2jMG5TE1H8z.h04eExb98pQ6wuWtuV8agN3j9o2p6EOZ08zgEACkRuWrkrcQPchS0txUbvvWc3 Txido.oSkOx0JYAWhxEwkvWKkN2dnrH6ab64FWaI7JrkdERppOzE5z0ZVX4GLT1s8hVpY0heyPIY q5RpV16v5vvh_5_oKG_BLg4u0YoOuJPirHJa3JQ4wwckASDHfX_l_AOhkMzBtGt283zfaszY.hru lkAVltmbDe6B8MtvR0GBHp9V1h7c_KP9CVnvx.VTC2GZ.H1UEcXrh9YcC97hZtZQGtOw2plVnN3S 6_h0ySJRnOMqSoNPYj_xrX50aBBFQASnf8OUibel.3RzvfV.kZaBT5Y08HucYzHFyo0EnVx1pG6B XV.DQ8M0pqB0exBLI5cFOaDk5zt.OeKpspJfnii69JTI8UMDmH9dIpettMKFj3CLOiurRLkJ9Hj9 ckvK4H6W1aO9hLbYixy0P6KlEfmIMXucYN4oeldNq5xiOISRwnBp9jQeBpISCYrsIWXPmEyF0Qrr jor5OsFkd7DO2NtqKCiBDQ3Eit7RB1pxnkej.yyeu8 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 15 Feb 2022 13:56:01 +0000 Original-Received: by kubenode501.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 67ee6ad730ef3fb8d07f8621d5010567; Tue, 15 Feb 2022 13:55:58 +0000 (UTC) In-Reply-To: <837d9w450e.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Feb 2022 15:46:09 +0200") X-Mailer: WebService/1.1.19724 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.83; envelope-from=luangruo@yahoo.com; helo=sonic306-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286330 Archived-At: Eli Zaretskii writes: > [Why private email?] Sorry for that, I copied in the list again. And I apologize for sending all of this twice. > But this means we cannot call the decoding stuff there at all, because > some coding-systems call into Lisp, and Lisp can signal an error. So > we probably should take the raw bytes in that place, record them in > the event queue, and then decode it later, when it's safe. What safe place would you find appropriate for the job? And I'm not sure if we have a mechanism in place to record the raw bytes that way, so one will have to be devised. > Are there other situations where we decode stuff inside > handle_one_xevent or in a XIM callback? There aren't any, AFAICT, other than the ones that I changed. > If so, and if what you write is really accurate, then we have a > ticking bomb waiting to go off, and we should defuse it ASAP. Indeed. > But given what you say above I think we have a much more serious > problem on our hands. Based on what you have said, I agree. Thanks in advance.