From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 4bd7963e2e: (add-hook, remove-hook): Fix leaks (bug#48666) Date: Wed, 23 Feb 2022 01:50:41 +0100 Message-ID: <87czje9zj2.fsf@gnus.org> References: <164554313281.19745.16002982422511613011@vcs2.savannah.gnu.org> <20220222151853.530B7C00894@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39419"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 23 01:57:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMfyK-000A43-Lv for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Feb 2022 01:57:36 +0100 Original-Received: from localhost ([::1]:49760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMfyJ-0002JU-59 for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Feb 2022 19:57:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMfrr-0007tC-PB for emacs-devel@gnu.org; Tue, 22 Feb 2022 19:50:56 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=46392 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMfrp-0007Ut-87 for emacs-devel@gnu.org; Tue, 22 Feb 2022 19:50:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YFUUM6Iv3rfxCR7ZRz66jovCbS3Zb2MGsJQktgZtcDQ=; b=jQD2e85XSbzVSUjNT4ggXMfenM +wECovWnif3lDXHik5N2jyhCYoQG9YrNM5WIGW10hJsBJr8JD9kOj5PKz9jqLuXk1/3GmoHrkZEeI Td6xqt2YSWdogD8uKFzYYLKxfLG05RsQgne+lxQqE3UyRigDFgecPVsFnrNVLgJlhhKY=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMfrg-0003OU-8n; Wed, 23 Feb 2022 01:50:47 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXj6Nr2+/m1vrdy ka8iJir///8Xv2xaAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YCFwAxOruWsHkAAAGzSURBVDjLXZTt lQMhCEXRpACcacDgFjARC8ju0H9NC6LzEX8kOVwReD4DIdlCGCvPH+CgryMGkTKc8YAQekLMd4AJ yx47yFeAL2wyAF3A0vYmDmCjTBM8pK+ZcYARFyHLqEQDlBmXzTK2PMDziMtfAHhu4MD37wTNgYYN xB+PW8ciHwURcyHYRztdmtVBtaPG2S8fUraQRlce/x1ytRwAgSLFAeb8KwRKgaKe1vt5ndJrjUA2 pki9XYllFBtfarosDCECVgOYbgBCTEux+0rfAELo13sHWiSG9G0GB90UUSW5kwDTLCL5njJtZpdz AxjcfibI+1pjCW69m1Qj4wS/XwAn2C8TKohHxlnFwLKbumwWkL8DRLVqjV0StJR6ASmSa9XOwxCi BaqDVY7DMLJ+6jtwdcv0CZYm2u1SB0ij5ZX1W8FayQG6n3U7czO11T1Xt++scTsSuc4b7I3pfu61 gPWp+T2txztgA9bW6H+GuYOnVh9gvKlaFAA++AGfMXGvwsT8TtlsDUO+2CQzaZzfqEMs2wTAEtQ0 lfht/xf8AZe1VANAhXkzoCZ1oMOJ2YwHAPgHbVl6Dnn0aKEAAAAldEVYdGRhdGU6Y3JlYXRlADIw MjItMDItMjNUMDA6NDk6NTcrMDA6MDBqB+UUAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTAyLTIz VDAwOjQ5OjU3KzAwOjAwG1pdqAAAAABJRU5ErkJggg== X-Now-Playing: David Bowie's _Lodger_: "Red Money" In-Reply-To: <20220222151853.530B7C00894@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Tue, 22 Feb 2022 10:18:52 -0500 (EST)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286609 Archived-At: Stefan Monnier via Mailing list for Emacs changes writes: > (add-hook, remove-hook): Fix leaks (bug#48666) > > * lisp/subr.el (add-hook, remove-hook): Rewrite the hook depth > management so we only keep the info relevant to functions present on > the hook. I have no idea why, but this seems to lead to these test failures: 3 unexpected results: FAILED electric-layout-mode-newline-between-parens-without-e-p-m FAILED electric-layout-mode-newline-between-parens-without-e-p-m-2 FAILED electric-pair-mode-newline-between-parens -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no