From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54536: 29.0.50; Improve ERC's handling of multiline prompt input Date: Wed, 23 Mar 2022 14:50:13 +0100 Message-ID: <87czic93sa.fsf__35121.8371813715$1648043480$gmane$org@gnus.org> References: <87k0ckg5pn.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4079"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-erc@gnu.org, 54536@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 23 14:51:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX1OJ-0000qK-Ic for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 14:51:11 +0100 Original-Received: from localhost ([::1]:33780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX1OI-0007et-2Z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 09:51:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX1OB-0007el-3N for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 09:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nX1OA-00087C-4w for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 09:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nX1OA-0006ht-3x for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54536 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54536-submit@debbugs.gnu.org id=B54536.164804342625731 (code B ref 54536); Wed, 23 Mar 2022 13:51:02 +0000 Original-Received: (at 54536) by debbugs.gnu.org; 23 Mar 2022 13:50:26 +0000 Original-Received: from localhost ([127.0.0.1]:43187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX1Na-0006gx-2A for submit@debbugs.gnu.org; Wed, 23 Mar 2022 09:50:26 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX1NY-0006gj-4d for 54536@debbugs.gnu.org; Wed, 23 Mar 2022 09:50:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ew+btwU4R6an/Ugi6pTomFQm6pgBRzaPCrbDnarKCU0=; b=nN/vvppDbECHIFkjBRu7ixlDcv Ehj/kB3YFb4885nGz//QMW2wBom6t3XqMlzY+aPds0BaHHfSPDXtCuVFEHO0vuq/Z98Djrnfrd3jg WuHZmtPF+ooLvgSjVNJ3YNSCJE7KR004vx3hlemYKiZWY/j6ZYxiyakke+VFZIT5GLJc=; Original-Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX1NO-0004IQ-Hh; Wed, 23 Mar 2022 14:50:16 +0100 In-Reply-To: <87k0ckg5pn.fsf@neverwas.me> (J. P.'s message of "Wed, 23 Mar 2022 06:26:44 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228810 Archived-At: "J.P." writes: > 1. What should happen when a user submits multiline input containing > empty lines? Should these be padded so they're not rejected by the > server? If so, where in the processing pipeline should that occur? > Should `erc-send-whitespace-lines' play a role here? > > This patch says yes to the latter and interprets that option as > meaning "preserve whitespace-only lines and create them as necessary > from blank ones." As to where padding should happen, this patch punts > and retains the existing (unfortunate) practice of treating them at > the last minute. Makes sense to me. > 2. Should trailing blank lines be treated differently? If so, how? > Should they be auto-padded? Simply dropped? Or should encountering > them raise an error? > > When `erc-send-whitespace-lines' is non-nil, this patch drops > trailing blanks by default, but it also provides an escape hatch. Dropping trailing blank lines is a good thing, I think. > 3. When `erc-send-whitespace-lines' is non-nil, should it auto-pad a > submission consisting of a single empty line? Should it allow a > whitespace-only singleton through? > > This patch says no to the first and yes to the second. Sounds good. > 4. Should slash commands, like /MSG be allowed to lead a multiline > submission? > > This patch says no, still choosing to interpret commands as always > consisting of a single line. Ditto. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no