From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Adding with-gensyms and once-only to subr-x Date: Mon, 11 Apr 2022 23:02:18 -0700 Message-ID: <87czhmdel1.fsf@melete.silentflame.com> References: <87sfqja2eu.fsf@melete.silentflame.com> <87bkx7tbar.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16090"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 08:04:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ne9dm-0003uN-Hc for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 08:04:39 +0200 Original-Received: from localhost ([::1]:59034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ne9dl-0001yE-Bm for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 02:04:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ne9bc-0001Dh-LL for emacs-devel@gnu.org; Tue, 12 Apr 2022 02:02:24 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:46241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ne9ba-0002kX-I0 for emacs-devel@gnu.org; Tue, 12 Apr 2022 02:02:24 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3EA023201C39; Tue, 12 Apr 2022 02:02:20 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 12 Apr 2022 02:02:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1649743339; x=1649829739; bh=8P 4/S+u2MeMTlYjRdK6o5NMFVC2sPN6pAieZIda7jyE=; b=lOzteES5g0J0D3rfy8 t253CwApEtwOhNBu//3ALsuyX3+qf0FOkx8VTmUcSlOZEzbnKTaA3zBeHcSv5L9h RXaa4DhNRT3tYbAOZ7XYANVPZH5Ex4bNH+p1w1ghP3q4Y04kU1hGUoJWbPqXy1ZL Kk1UqC13GA+kfgXsiOF4N0w+BjQV5UwtwYpJj6KijPwl7TituE4LQfwcuBolzkAU 4mVvFZZKosZtrNew3UaoZS/aKTYWPKVn6pQQFlV1lPPLUgI+Zi26Zsuxf4hFEXoY cwIMjh+cJgUlEPnjnPYy8Zqlp/UygUDgNt/dqoLr2cBrYHogqfv3StsdmHJoVKS2 vjOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1649743339; x= 1649829739; bh=8P4/S+u2MeMTlYjRdK6o5NMFVC2sPN6pAieZIda7jyE=; b=a zAGc66gMYZSEJJ/TiBDTex1lBooSQ1XTFxFB3erY6ZupdJ3RBfk/Cmh6YPFZnrnG mAvYzbKbD5jIPkZZiDcQ0lJo/39dP+iRsiY2XZKjKogXJdXVCYFS2d0dm2KfCVRy 6X0RBNIcpHlCVE9ZoMXXu34XY9SzpSuA5Am41pCVwwftnbi1h4e6cv3GOL5uM5gf gwdA3ptv+fx6YCmKrrQGi+193CXKlcJ6wnFk7hTojmohb0O34BCLTF6g+IQLltHh 9QLUITJUDb+aqOCFD37+V0wMUjZiZc5yaPRU7R8a45rM2H8cqGtqreHTdXeDsvAg lCO+ZNYnDxOnwjvlpJtHw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekjedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeelgeeggfdvieejvdfhudfggeetgfekkeeuieeljeejhedu geegfeetgefhueffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Apr 2022 02:02:19 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id DA0867E3E57; Mon, 11 Apr 2022 23:02:18 -0700 (MST) In-Reply-To: Received-SPF: pass client-ip=64.147.123.21; envelope-from=spwhitton@spwhitton.name; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288266 Archived-At: Hello, On Mon 11 Apr 2022 at 11:08PM -04, Stefan Monnier wrote: >> At the very least this should be noted in the docstring for >> cl-once-only, but maybe it means cl-once-only should use the code in my >> original patch and not use macroexp-let2* at all? What do you think? > > It's not very important that it use `macroexp-let2*` internally. Cool, pushed, thanks again! -- Sean Whitton