all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: 15775@debbugs.gnu.org, "Jan Djärv" <jan.h.d@swipnet.se>,
	schwab@linux-m68k.org,
	"Ulrich Neumerkel" <ulrich@complang.tuwien.ac.at>,
	4359@debbugs.gnu.org
Subject: bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell
Date: Thu, 05 May 2022 14:42:49 +0200	[thread overview]
Message-ID: <87czgsqhfa.fsf_-_@gnus.org> (raw)
In-Reply-To: <m3wrg0x3kg.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Sat, 02 Jul 2011 14:35:59 +0200")

This change makes "git grep" work as a grep command with `M-x grep' (if
you remove --null).  It's shouldn't have a negative impact on much
anything else (because no pagers should be used anywhere here), but
perhaps it should be done in grep.el instead of compile.el...

Anybody got any comments?

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6753cf0b02..c88eb10693 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1895,6 +1895,9 @@ compilation-start
               (and (derived-mode-p 'comint-mode)
                    (comint-term-environment))
 	      (list (format "INSIDE_EMACS=%s,compile" emacs-version))
+              ;; Some external programs (like "git grep") use a pager;
+              ;; defeat that.
+              (list "PAGER=")
 	      (copy-sequence process-environment))))
         (setq-local compilation-arguments
                     (list command mode name-function highlight-regexp))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no






  reply	other threads:[~2022-05-05 12:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-06 16:09 bug#4359: 23.1.50; ^G in M-x grep mode with git grep Ulrich Neumerkel
2009-09-06 16:57 ` Andreas Schwab
2009-09-06 17:05   ` Ulrich Neumerkel
2009-09-06 17:15     ` Andreas Schwab
2011-06-30 23:44       ` Lars Magne Ingebrigtsen
2011-06-30 23:50         ` Ulrich Neumerkel
2011-07-01  0:01           ` Lars Magne Ingebrigtsen
2011-07-01  1:11             ` Juri Linkov
2011-07-01  6:58             ` Jan Djärv
2011-07-01 10:13               ` Lars Magne Ingebrigtsen
2011-07-01 16:48                 ` Dan Nicolaescu
2011-07-02 12:35                   ` Lars Magne Ingebrigtsen
2022-05-05 12:42                     ` Lars Ingebrigtsen [this message]
2022-06-02 13:07                       ` bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell Lars Ingebrigtsen
2022-06-04 17:37                         ` Dmitry Gutov
2022-06-05 14:15                           ` bug#4359: " Lars Ingebrigtsen
2009-09-06 17:37     ` bug#4359: 23.1.50; ^G in M-x grep mode with git grep Sven Joachim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czgsqhfa.fsf_-_@gnus.org \
    --to=larsi@gnus.org \
    --cc=15775@debbugs.gnu.org \
    --cc=4359@debbugs.gnu.org \
    --cc=dann@gnu.org \
    --cc=jan.h.d@swipnet.se \
    --cc=schwab@linux-m68k.org \
    --cc=ulrich@complang.tuwien.ac.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.