all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Tyler Grinn <tylergrinn@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Re: Concatenate properties
Date: Thu, 12 May 2022 17:59:37 +0800	[thread overview]
Message-ID: <87czgjhy0m.fsf@localhost> (raw)
In-Reply-To: <874k1w2c6o.fsf_-_@gmail.com>

Tyler Grinn <tylergrinn@gmail.com> writes:

> OK, what I have now is that if the car of an alist item is a list, exact
> matching will be done for each list item, but if it is a string, it will
> be matched as a regular expression.

Sounds reasonable.

Note that your patch is >15LOC long and you need to sign the copyright
agreement with FSF in order to contribute. See
https://orgmode.org/worg/org-contribute.html#copyright

Some comments on the patch:

> * lisp/org.el (org-property-separators, org-property-get-separator):
> Created.

I'd make the function private: org--property-get-separator. It is not
intended as an API function.

> (org-entry-get, org-entry-get-with-inheritance): Use new
> org-property-get-separator function.

> org-property-separators is a customization option that allows for

Please quote the function name as `org-property-get-separator'.

> +If a property is specified multiple times with a =+=, like
> +=:EXPORT_FILE_NAME+:=, the old behavior was to always combine them
> +with a single space. For the new variable, the car of each item in
> the

Please, use double space "  " to separate sentences. Also, see
doc/Documentation_Standards.org

> +For example, in order to combine =EXPORT_FILE_NAME= properties with a
> +forward slash =/=, one can use
> +
> +#+begin_src emacs-lisp
> +(setq org-use-property-inheritance '("EXPORT_FILE_NAME")
> +      org-property-separators '((("EXPORT_FILE_NAME") . "/")))
> +#+end_src

This example is a bit confusing because it is unclear what you want to
achieve and why you also need to set inheritance.

> +(defcustom org-property-separators nil
> ...
> +  :group 'org-properties
> +  :type '(alist :key-type string :value-type sexp))

This defcustom type does not match what you described in the docstring.
You need something like :type '(alist :key-type (choice string (repeat string)) :value-type string)

Best,
Ihor


  reply	other threads:[~2022-05-12 10:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 22:37 Concatenate properties Tyler Grinn
2022-05-05 22:56 ` John Kitchin
2022-05-06 15:40   ` Tyler Grinn
2022-05-07  5:33     ` Ihor Radchenko
2022-05-07 11:44       ` John Kitchin
2022-05-07 12:29         ` Tyler Grinn
2022-05-08 12:21           ` Ihor Radchenko
2022-05-08 14:14             ` Tyler Grinn
2022-05-08 14:47               ` Ihor Radchenko
2022-05-09 20:18                 ` Tyler Grinn
2022-05-11 11:51                   ` Ihor Radchenko
2022-05-11 17:47                     ` [PATCH] " Tyler Grinn
2022-05-12  9:59                       ` Ihor Radchenko [this message]
2022-05-12 23:27                         ` Tyler Grinn
2022-05-13 12:21                           ` Ihor Radchenko
2022-05-14  2:11                             ` Tyler Grinn
2022-05-20  8:04                             ` Ihor Radchenko
2022-05-07 13:20     ` John Kitchin
2022-05-07 14:09       ` Tyler Grinn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czgjhy0m.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tylergrinn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.