From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YJVQN12A0mKZYwEAbAwnHQ (envelope-from ) for ; Sat, 16 Jul 2022 11:09:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gG06N12A0mLJSwEAauVa8A (envelope-from ) for ; Sat, 16 Jul 2022 11:09:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 796D03CEF1 for ; Sat, 16 Jul 2022 11:09:33 +0200 (CEST) Received: from localhost ([::1]:49746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCdnn-00054W-MC for larch@yhetil.org; Sat, 16 Jul 2022 05:09:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCdn4-00054L-Q3 for emacs-orgmode@gnu.org; Sat, 16 Jul 2022 05:08:46 -0400 Received: from mail-oo1-xc2e.google.com ([2607:f8b0:4864:20::c2e]:33568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCdn3-0003Ld-3v for emacs-orgmode@gnu.org; Sat, 16 Jul 2022 05:08:46 -0400 Received: by mail-oo1-xc2e.google.com with SMTP id e2-20020a4ab982000000b004354ba9a591so1312067oop.0 for ; Sat, 16 Jul 2022 02:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HhIgcfLVJ6SOjzSVFrwPivFEs1DZv+heSI5QoUdveIs=; b=XsxRgT0IHd9PdCslPwwM2E0bQN4ugyrbNzilcg4X0+Xy3CZHsAGGKE2T+mSDKTn/A/ toMVvRvWv94dPSNsq5QCLiIvzX8RbohLkfG8CZIEhJHVIYbVEnAP45XJUJsWjHRnjdk7 JJV91x0AEbXsRcJpiIqSA9yAKGIhfpfldIUliW3FQhfxhRloKsuhrWQ3WZROgC41Gc3y U+Jtswkpf+majFCw1DdjqGINp+jRctyM0mvdbdGOOUTViBDkzG7gSD4mlYtJQdxaoFQq oaENzDC9UGU7X7K7u6J0BoTfyzcT9l+50CoX46aa034yOpOjVg7brJZueZfAclmYyiLP zang== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HhIgcfLVJ6SOjzSVFrwPivFEs1DZv+heSI5QoUdveIs=; b=me+rrq0bIDhcf2rVSmuL1GIh3K9Q0lQKdm6gPY/fBgtZ/dG2mt34mAXPmN283t2eCn Xr8pmGpiRn5YYMDIYnl6+qtbpGZ8c4zJ7Aw9TBiPF54vlGa2owf6svIjJqaDfSkSj2rp Lx5fgfKaTy/Iizg5OgjOxxkSfQfdbEFkNx59CuXd3mZgcZdKYdetw0sVIvvmZRvRz4S+ UYlLe6yghfSJO6i9O+gWcqZcu34at9Fwjx7huQqnxwaXYmtgsUKn6ThPMo6nVf0LTdOs wEQIvRYlUQmQn/haIsUfu+ApGwkykZPZyHZVVB4/SKkLQzujKA+/6Qokzgg2pV4iG8jx zuWQ== X-Gm-Message-State: AJIora+VWCuStq7OGLWsctY+qZIDCtrzV+DbLrkzBONr5of1vDZ0tFX6 vOzRjyatyFoTgzZT/ovshOQ0ZDObTvk= X-Google-Smtp-Source: AGRyM1s7Q9laNq1AQxolHAOe7ILBWoRkYsKR/dL6L2Br9V6nPpV8AGXajWbYgNEdOd+zkau06ZWjuQ== X-Received: by 2002:a4a:d552:0:b0:435:81c5:43ab with SMTP id q18-20020a4ad552000000b0043581c543abmr1827628oos.9.1657962523967; Sat, 16 Jul 2022 02:08:43 -0700 (PDT) Received: from localhost ([2409:8a70:2bd:4d0:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id q14-20020a05683022ce00b0061c87262540sm1206630otc.65.2022.07.16.02.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 02:08:43 -0700 (PDT) From: Ihor Radchenko To: Hugo Heagren Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters In-Reply-To: <877d4flu3x.fsf@heagren.com> References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> <871qvixhfw.fsf@gmail.com> <87v8s8n1bm.fsf@heagren.com> <87let39d3c.fsf@localhost> <877d4flu3x.fsf@heagren.com> Date: Sat, 16 Jul 2022 17:09:45 +0800 Message-ID: <87cze5e84m.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::c2e; envelope-from=yantar92@gmail.com; helo=mail-oo1-xc2e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657962573; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HhIgcfLVJ6SOjzSVFrwPivFEs1DZv+heSI5QoUdveIs=; b=qukEE2aLn30ioX9JdVXXyPdPWN187Pw/X108fw4+sTuZ09bKXI9+upPKbk27eCtRze5PaW MURnaUW1TG3E9AVSqQ/DmueSsRRcA3jVhYhsjiwkyo4oR1S3ubzFsMDFnRbTAuWUPNb9qQ Cj5Bx0pOTAB0A9g9jVcvuLQmgpBmaAhSpxTbdoiB9zvtUQmetvfSZ8LzrudlDSptFQ5A4F qCrROXtezTNI1fjnSeXIRc75jMKOOq4xIDwl0vdRqcciQnWoyUZ5eA17anYG3BRDxRlHiR oH8fz0h06dw7TUBOQa0DlwYunPSebThyg2UiW2NlRntNGz8U1mK3IpZ8Ake8AQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657962573; a=rsa-sha256; cv=none; b=CXtU3g28XsGpMyG3PfR8Kkgvk+Z0BCDTRHC3WEblz2eqR+24LHKV1orZOGLd7teO6BEKRX qQ78gd8VvU10IB7ggecg6ZqpvhtE514/yS/6aC/RuZj/zHZIMlCpPXGy6rKlsbU8xnsbHG oYIkhtV2BRzYt7vkaXPYoamUnITBX1oGrhCNWQoWhm7Y6Ymfr5WppRkQ8EHekHUwblqrHN auPbwRs47J5j1Hcv9qo65E+SWvygcp9DJajifrcsmjJi93giNo+SoU4Q28/Rxn8VyhH23t MqEvdn1WvWi//USTZ9sbWNpm6OeeE1c7HyZgPhatFghX0PesZ+gCIvRdlbm6Lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XsxRgT0I; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.54 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XsxRgT0I; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 796D03CEF1 X-Spam-Score: -5.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: kHHCcImJxLe7 Hugo Heagren writes: >> Currently, the internal implementation will treat nil return value as if >> there was no :default-description and org-link-make-description-function >> were set to nil. We may probably document this. It sounds like a useful >> behavior. > > I added some relevant documentation to the `:default-description' part > of the `org-link-parameters' docstring. I also changed the > previosly-failing test to expect the right value. All the tests pass > now. Thanks! Can you also update the documentation for org-link-make-description-function? > From cd5268bc05324140a4cf384ce12b99bba1ddab47 Mon Sep 17 00:00:00 2001 > From: Hugo Heagren > Date: Mon, 28 Mar 2022 23:18:45 +0100 > Subject: [PATCH] ol.el: add description format parameter to > org-link-parameters Also, can you please review the comments from Max: https://list.orgmode.org/877d4flu3x.fsf@heagren.com/T/#m3b48d0076a25eaf24b1af48df317984dd4e33fb0 > + ;; Copy all keys in `parameters' and their original values to > + ;; `orig-parameters'. > + (cl-loop for param in parameters by 'cddr > + do (setq orig-parameters > + (plist-put orig-parameters param (org-link-get-parameter type param)))) Thinking about this part a bit more, I have realized that even better option would be using map-do. Best, Ihor