From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sN2eI9HHCGMMhAAAbAwnHQ (envelope-from ) for ; Fri, 26 Aug 2022 15:17:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8EBqI9HHCGMdKgEAauVa8A (envelope-from ) for ; Fri, 26 Aug 2022 15:17:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2528C9F55 for ; Fri, 26 Aug 2022 15:17:05 +0200 (CEST) Received: from localhost ([::1]:56942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRZCp-0005lS-Tw for larch@yhetil.org; Fri, 26 Aug 2022 09:17:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZAW-0005lE-3N for emacs-orgmode@gnu.org; Fri, 26 Aug 2022 09:14:40 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:45888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRZAT-0002jV-Mg for emacs-orgmode@gnu.org; Fri, 26 Aug 2022 09:14:39 -0400 Received: by mail-pl1-x62c.google.com with SMTP id u22so1540818plq.12 for ; Fri, 26 Aug 2022 06:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=uM7jdG3UGfxktRVez5M+n+xCR2152C6Rn1hLZPANfGA=; b=ouMZTAbpW4cL1K0eIPfZBsRZHVI+NkvSGj31fBxIsLChe5S5pT8P7APGg73WN2jbx5 ILw2SaphujeSiGO6Z6lpkGICnSSElEmjaUY9l2SntcVBiA3xWlXa3qfW+28Lm7lyKQZ6 6dvMV9zH9IDYhUWcWLDH3eDnPcYTSTF8Tba8vmMx4s/bnXxWqCRM2fFTbzuj5+lJVNmi 3Kpc4xJ+ixZ4/xkdG3P4NfMZ3U4ziqH9xJSLFB3RnVBkJWlCz67l4iKXNP+Drtdzmuk/ UlkMEONs2vf6SW7hAMPReRbLePuy8/CZNdpUOT1k7jCDabnMigPN0M5c4+EBuW8frE86 rlZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=uM7jdG3UGfxktRVez5M+n+xCR2152C6Rn1hLZPANfGA=; b=dxFWSOb1ZrnZPjS8I5ChliV/3TDPXY/MNgikwhCGR8A0IIRflh8nXJnuU9srwVX4Bq 33St1mk3+AATjzb9Wo8bwplXoumaaJnglLIW96e/LFl358otPATC201wvsykjrkRzEoU 4kDqcwwwbx60Qx/y1TMW1LCISuX9sEDuFs+C8lyDlS2ZdUtEIjk3Gk+pSIZkHE2jk9iP Zd5I/pWRxGkQCS4FYesJPHvojQNtxE2jUdYlYxP1JXZI+X9dpmXUaTkwjH3Y8vLuk6QI J6d318WTe6PWWv7VYwMLsCQtjfuBQ6h0KDVAKP+TtCPkFKhDq91i01rEFyfCaLnGkoj+ BEFA== X-Gm-Message-State: ACgBeo3njSurbFwfiBbH8lWyJsyG5zDdyv+vS8tSzeru91gTq6+mXfbG VIl8gEdDvPG2f0o2GUHwzm8= X-Google-Smtp-Source: AA6agR7o0Q6SnNvI177Luj6ctejqff9X02/11sUjoDOqXJhiTGlLRKX1s8BeQ9nfGFj8bA7a/xerKA== X-Received: by 2002:a17:90b:4b4e:b0:1fb:3c38:28ea with SMTP id mi14-20020a17090b4b4e00b001fb3c3828eamr4474011pjb.131.1661519673418; Fri, 26 Aug 2022 06:14:33 -0700 (PDT) Received: from localhost ([2409:8a70:2b3:c8a0:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id 18-20020a621412000000b0053725e331a1sm1658574pfu.82.2022.08.26.06.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 06:14:32 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v3] ol-info: Define :insert-description function In-Reply-To: References: <87zgl1npow.fsf@localhost> <87mtd0gthe.fsf@heagren.com> <78b97c9e-fced-0ee4-f3f2-3cbe81080ffa@gmail.com> <87sfms9dx7.fsf@localhost> <87v8rmd53g.fsf@localhost> <871qu9xv8q.fsf@heagren.com> <0da49392-26c6-8ba3-f657-647522d59342@gmail.com> <87zggrg2om.fsf@heagren.com> <87edy3t8o0.fsf@localhost> <87tu6zf2o1.fsf@heagren.com> <871qu3rpt9.fsf@localhost> <8bbccdb4-52f4-b9b5-eb10-252bb15108ec@gmail.com> <87a68hn9es.fsf@localhost> <87zgg0q2kz.fsf@localhost> <877d33nzjd.fsf@localhost> <871qt8ly06.fsf@localhost> Date: Fri, 26 Aug 2022 21:15:35 +0800 Message-ID: <87czcnxi14.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661519825; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uM7jdG3UGfxktRVez5M+n+xCR2152C6Rn1hLZPANfGA=; b=t95DlmXffz0hiuFguOJkZ2QiF6YkF6RZVU2TLJmVpNanslM2+3QibOOfhkOw5L8jNOqa7g Zt0bu5mKcp+GeqfV5P04KrWLLfig1+SL9y8uMfY3kqatzTd2Iv+8la6uWXWFbQowrqdEMH X30TdEtV/hWlyCAVBr2yC5RQKzgmJ1Y5BliOpDmfuuIfb6SfCTVM7tN98YoqMvB1VcAh3i VHVc6miZjgx4Pug8L76jr7L51cyIxjpxRYG3hDdl4N4ZtKRT/0BBW8XoGRmN+kPH1dy3xo LAvzcTqRxle04YDQpElbwIvvN+Ca6E732/FjZlVViTh7dsK3YshRMCULzyZ1xg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661519825; a=rsa-sha256; cv=none; b=Xb2QpKylE2iNHhVT/ufECdl8+IxJ250FuKnkP1FONBJ+KYqg4yQmiR0H/BKa4qIIgpU7zP Lw0SvXrdN/0jZblB4BBiJIFeqMXtvukZaKywJICMM0URpx5dSliAFWcTYkKWVRpiJito8Q 1ULXcFlCYvJtBaOnSAPg8e6xCQBAs5/PNg/GU0gXKfqNeLmXn//+x1YF32ER+0uycENgQ1 5oJu8mGglHvfDBiSwEv360849WmP3fnGZJC14yHFpzhlYj4PWjyBAUIwI+9vD20bgiIiVn kFiL2rIqTXCGuvQUJhYL+zUmhLQ6lWT2IdtwFicyC/IeeLcF9ZdXpIAll36F7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ouMZTAbp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.31 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ouMZTAbp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2528C9F55 X-Spam-Score: -8.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: zz7waIaNZGwO Max Nikulin writes: > On 22/08/2022 11:10, Ihor Radchenko wrote: >> >> Maybe, in addition to "Return cons consisting of file name and node name", >> you can put something like "File name may also be a virtual file name >> (see `Info-virtual-files')." > > I have tried to fix docstrings. Thanks! LGTM now. Applied onto main via 372788a18. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=372788a18933b9ed38b747e5f5429ea39d71106a >> I am ok with current behavior. It is only the docstring that I find >> slightly confusing. > > I am still unsure how to treat links with missed filename, so I changed > it from "(org) Something" to "(dir) Something". The latter is not valid, > but it is more consistent with "(dir) Top" for "info:" (empty path) links. Let's not overthink edge cases. Unless we can reasonably expect some specific invalid links in the wild, there is no reason to be too smart here. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92