all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: "Emacs-devel@gnu.org" <Emacs-devel@gnu.org>
Subject: Re: "Eager macro-expansion failure: (excessive-variable-binding)"
Date: Wed, 14 Sep 2022 17:15:01 +0200	[thread overview]
Message-ID: <87czby6l8q.fsf@gnus.org> (raw)
In-Reply-To: <D10472B9-CD2C-4C15-A6A6-0AB269140838@gmail.com> ("Mattias Engdegård"'s message of "Wed, 14 Sep 2022 16:16:06 +0200")

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> This isn't ideal (probably makes build times go up a bit, maybe Lars
> can see it on his graphs?)

Hm...  yes, it seems like this (or something else recently) increased
the "make -j32" build time from 1:08m to 1:17m, which is pretty
significant.  I'm doing further rebuilds to see if that's indeed the
culprit.

> I suggest we do something about the vc-git-annotate-switches problem
> anyway for general performance reasons,

It's a general issue with adding variables that are supposed to be safe
file-local in this way, I guess?  Perhaps we should instead `put' the
safe-local stuff in a central file that doesn't trigger loading the file
where the variable is defined?




  reply	other threads:[~2022-09-14 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 12:18 "Eager macro-expansion failure: (excessive-variable-binding)" Lars Ingebrigtsen
2022-09-14 14:16 ` Mattias Engdegård
2022-09-14 15:15   ` Lars Ingebrigtsen [this message]
2022-09-14 15:38     ` Lars Ingebrigtsen
2022-09-14 16:50       ` Eli Zaretskii
2022-09-14 16:52         ` Lars Ingebrigtsen
2022-09-14 16:55           ` Eli Zaretskii
2022-09-14 17:03             ` Lars Ingebrigtsen
2022-09-14 17:09               ` Eli Zaretskii
2022-09-14 17:18                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czby6l8q.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=Emacs-devel@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.