* Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection
[not found] ` <20220916185735.5AAFBC00874@vcs2.savannah.gnu.org>
@ 2022-09-17 10:40 ` Philip Kaludercic
2022-09-17 12:30 ` Protesilaos Stavrou
0 siblings, 1 reply; 3+ messages in thread
From: Philip Kaludercic @ 2022-09-17 10:40 UTC (permalink / raw)
To: emacs-devel; +Cc: Protesilaos Stavrou
ELPA Syncer <elpasync@gnu.org> writes:
> branch: externals/ef-themes
> commit 71fb847ecaed028f2c7f4b798d311b8e59df3db1
> Author: Protesilaos Stavrou <info@protesilaos.com>
> Commit: Protesilaos Stavrou <info@protesilaos.com>
>
> Add FIXME about simplifying ef-themes-collection
> ---
> ef-themes.el | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ef-themes.el b/ef-themes.el
> index d082d7dc6e..0a6b04e59a 100644
> --- a/ef-themes.el
> +++ b/ef-themes.el
> @@ -48,6 +48,9 @@
>
> ;;; User options
>
> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
> +;; This duplication seems unnecessary.
> (defconst ef-themes-collection
> '(ef-autumn
> ef-dark
Is there any reason you couldn't just replace the definition with
(seq-union ef-themes-light-themes ef-themes-dark-themes)
?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection
2022-09-17 10:40 ` [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection Philip Kaludercic
@ 2022-09-17 12:30 ` Protesilaos Stavrou
2022-09-17 13:04 ` Philip Kaludercic
0 siblings, 1 reply; 3+ messages in thread
From: Protesilaos Stavrou @ 2022-09-17 12:30 UTC (permalink / raw)
To: Philip Kaludercic, emacs-devel
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Sat, 17 Sep 2022 10:40:32 +0000
> [... 21 lines elided]
>> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
>> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
>> +;; This duplication seems unnecessary.
>> (defconst ef-themes-collection
>> '(ef-autumn
>> ef-dark
>
> Is there any reason you couldn't just replace the definition with
>
> (seq-union ef-themes-light-themes ef-themes-dark-themes)
>
> ?
You mean to include that in the relevant functions and remove the
'ef-themes-collection' altogether? I was thinking that having a
standalone variable is easier for documentation purposes. Same for
'ef-themes-{dark,light}-themes'.
Though yes, your code does what I want.
--
Protesilaos Stavrou
https://protesilaos.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection
2022-09-17 12:30 ` Protesilaos Stavrou
@ 2022-09-17 13:04 ` Philip Kaludercic
0 siblings, 0 replies; 3+ messages in thread
From: Philip Kaludercic @ 2022-09-17 13:04 UTC (permalink / raw)
To: Protesilaos Stavrou; +Cc: emacs-devel
Protesilaos Stavrou <info@protesilaos.com> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Sat, 17 Sep 2022 10:40:32 +0000
>
>> [... 21 lines elided]
>
>>> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
>>> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
>>> +;; This duplication seems unnecessary.
>>> (defconst ef-themes-collection
>>> '(ef-autumn
>>> ef-dark
>>
>> Is there any reason you couldn't just replace the definition with
>>
>> (seq-union ef-themes-light-themes ef-themes-dark-themes)
>>
>> ?
>
> You mean to include that in the relevant functions and remove the
> 'ef-themes-collection' altogether?
I was thinking of replacing the
'(ef-autumn
ef-dark
with the `seq-union' call from above.
> I was thinking that having a
> standalone variable is easier for documentation purposes. Same for
> 'ef-themes-{dark,light}-themes'.
>
> Though yes, your code does what I want.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-17 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166335465493.17197.7832233071746944297@vcs2.savannah.gnu.org>
[not found] ` <20220916185735.5AAFBC00874@vcs2.savannah.gnu.org>
2022-09-17 10:40 ` [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection Philip Kaludercic
2022-09-17 12:30 ` Protesilaos Stavrou
2022-09-17 13:04 ` Philip Kaludercic
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.