From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Tue, 11 Oct 2022 19:20:18 +0000 Message-ID: <87czay5frh.fsf@posteo.net> References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> <83o7uki5ol.fsf@gnu.org> <87tu4c5g9j.fsf@thornhill.no> <835ygshz6k.fsf@gnu.org> <87zge3jj0j.fsf@gnus.org> <83o7uig9dm.fsf@gnu.org> <9E2D0EEB-3910-4C58-96E7-68E7C84E5097@thornhill.no> <87pmeyesty.fsf@thornhill.no> <878rlmgql1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Theodor Thornhill , Jostein =?utf-8?Q?Kj=C3=B8nigs?= =?utf-8?Q?en?= , Eli Zaretskii , acm@muc.de, emacs-devel@gnu.org, jostein@kjonigsen.net To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 21:23:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiKqc-0008pq-AD for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 21:23:26 +0200 Original-Received: from localhost ([::1]:59250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiKqa-0004S1-Qc for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 15:23:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiKnh-0002aT-Tk for emacs-devel@gnu.org; Tue, 11 Oct 2022 15:20:26 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:55473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiKnf-0004h6-VJ for emacs-devel@gnu.org; Tue, 11 Oct 2022 15:20:25 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F35F6240105 for ; Tue, 11 Oct 2022 21:20:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665516021; bh=oV6bBiqYcBTSd0dVEEqse+dRYmip5lsQU9k7tr0Cj3Q=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=mKX1b2g5YdeaYJXI+JGEZUwk1cUcim/L6jGDG9OHZQsmHmtayQmsDU3sMsAXjN6mk XToyLCBsU6vfaJHlAkTCfZQAsEnlE2PeGzW7dwdqiTZXpdY+1FKWFxyR5UkFegylVo jUjmP1tPRCDC6Ke414l5WzlxcPOGvRzYu/xvkbqJB8lVFR6Oc7DJOl/1NuHYgN5Cxt DWB4D7oCO4/F8vC8KXt3E4WnOtEyBK9GIYhlbu+NU+fvqxEGEVYZYtgXiLzVOzQJ6D jLCk/VrC19JaNAN1K3aTDU4aPvPYZdERgo0w4eAKi9dbTq+09Y9yY3JKH1WBQkBWo5 4smxKxmS9yJJA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mn5GC3yqtz6tml; Tue, 11 Oct 2022 21:20:19 +0200 (CEST) In-Reply-To: <878rlmgql1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 11 Oct 2022 20:31:06 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297531 Archived-At: Lars Ingebrigtsen writes: > Theodor Thornhill writes: > >> How about deprecating typescript.el the moment the 29.1 branch is cut? >> After we can but some sort of structure in place for the two to coexist? > > It doesn't work that way -- people will have the old typescript-mode in > their ~/.emacs.d/elpa/ files for years still to come, and things will > just be messy. > > So I think the way forward here would be to just plonk the new code into > the package, but choose totally different code paths depending on > whether we're in Emacs 29 (and have tree-sitter) or not. Then you can > start removing the non-tree-sitter code from the file afterwards. Perhaps I missed something, but why not just name the new mode 'ts-mode' (just like we jave 'js-mode' not 'javascript-mode')?