proposal: vc-print-log and vc-print-root-log include phases for hg

proposal: vc-print-log and vc-print-root-log include phases for hg

[Uwe Brauer]

Hi

Phases in mercurial allow you to detect if a commit has been pushed
(phase: public) or not (phase: draft (or even secret))


Could that information included in 
vc-print-log and vc-print-root-log include phases for hg?

Regards

Uwe Brauer 

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Dmitry Gutov]

Hi!

On 26.10.2022 15:26, Uwe Brauer wrote:

> Phases in mercurial allow you to detect if a commit has been pushed
> (phase: public) or not (phase: draft (or even secret))
> 
> 
> Could that information included in
> vc-print-log and vc-print-root-log include phases for hg?

Are you able to add them through `vc-hg-log-switches`?

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 2674 bytes --]

>>> "DG" == Dmitry Gutov <dgutov@yandex.ru> writes:

> Hi!
> On 26.10.2022 15:26, Uwe Brauer wrote:

>> Phases in mercurial allow you to detect if a commit has been pushed
>> (phase: public) or not (phase: draft (or even secret))
>> Could that information included in
>> vc-print-log and vc-print-root-log include phases for hg?

> Are you able to add them through `vc-hg-log-switches`?

Well not really, but it might be my fault for not understanding its syntax.


From the command line it would be 

 hg log -G --template "phases"

For example

So I thought 
the setting 

"--template \"phases\""


Would do, using the string syntax but it does not work
so I used a list 

 ("--template \"phases\"")

Then I obtain

,----
| hg log: option --template "phases" not recognized
| hg log [OPTION]... [FILE]
| 
| show revision history of entire repository or files
| 
| options ([+] can be repeated):
| 
|  -f --follow              follow changeset history, or file history across
|                           copies and renames
|  -d --date DATE           show revisions matching date spec
|  -C --copies              show copied files
|  -k --keyword TEXT [+]    do case-insensitive search for a given text
|  -r --rev REV [+]         show the specified revision or revset
|     --removed             include revisions where files were removed
|  -u --user USER [+]       revisions committed by user
|  -b --branch BRANCH [+]   show changesets within the given named branch
|  -P --prune REV [+]       do not display revision or any of its ancestors
|  -p --patch               show patch
|  -g --git                 use git extended diff format
|  -l --limit NUM           limit number of changes displayed
|  -M --no-merges           do not show merges
|     --stat                output diffstat-style summary of changes
|  -G --graph               show the revision DAG
|  -T --template TEMPLATE   display with template
|  -I --include PATTERN [+] include names matching the given patterns
|  -X --exclude PATTERN [+] exclude names matching the given patterns
|     --mq                  operate on patch repository
| 
| (use 'hg log -h' to show more help)
`----

That seems absurd since I just run that command from the command line,


I am puzzled.


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

>>> "DG" == Dmitry Gutov <dgutov@yandex.ru> writes:

> Hi!
> On 26.10.2022 15:26, Uwe Brauer wrote:

>> Phases in mercurial allow you to detect if a commit has been pushed
>> (phase: public) or not (phase: draft (or even secret))
>> Could that information included in
>> vc-print-log and vc-print-root-log include phases for hg?

> Are you able to add them through `vc-hg-log-switches`?

 ("G -template \"phases\"")

Does not return error, but does not show the phases neither. A BUG?

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Robert Pluim]

>>>>> On Thu, 27 Oct 2022 19:35:43 +0200, Uwe Brauer <oub@mat.ucm.es> said:

    Uwe> Would do, using the string syntax but it does not work
    Uwe> so I used a list 

    Uwe>  ("--template \"phases\"")

Thatʼs not a list of strings, thatʼs a list of one string. What does

("--template" "phases")

produce?

Robert
-- 

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Dmitry Gutov]

On 27.10.2022 20:35, Uwe Brauer wrote:
>  From the command line it would be
> 
>   hg log -G --template "phases"

Ah okay, if the --template option is required, it seems like you will 
need to change the vars vc-hg-log-format and/or vc-hg-root-log-format.

You can try that out locally, and maybe propose a patch.

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

>>> "RP" == Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Thu, 27 Oct 2022 19:35:43 +0200, Uwe Brauer <oub@mat.ucm.es> said:
Uwe> Would do, using the string syntax but it does not work
Uwe> so I used a list 

Uwe> ("--template \"phases\"")

> Thatʼs not a list of strings, thatʼs a list of one string. What does

> ("--template" "phases")

Does not help
> produce?

> Robert

-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

>>> "DG" == Dmitry Gutov <dgutov@yandex.ru> writes:

> On 27.10.2022 20:35, Uwe Brauer wrote:
>> From the command line it would be
>> hg log -G --template "phases"

> Ah okay, if the --template option is required, it seems like you will
> need to change the vars vc-hg-log-format and/or vc-hg-root-log-format.
Ok I will try this later

> You can try that out locally, and maybe propose a patch.

ok


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: proposal: vc-print-log and vc-print-root-log include phases for hg

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

>>> "DG" == Dmitry Gutov <dgutov@yandex.ru> writes:

> On 27.10.2022 20:35, Uwe Brauer wrote:
>> From the command line it would be
>> hg log -G --template "phases"

> Ah okay, if the --template option is required, it seems like you will
> need to change the vars vc-hg-log-format and/or vc-hg-root-log-format.

> You can try that out locally, and maybe propose a patch.

Ok the change/«patch» for vc-hg-log-format is straightforward and works as expected 

However right now I obtain a (python) error when running vc-print-root-log
that seems totally unrelated to emacs. So I need to solve this before trying out to modify vc-hg-root-log-format.


-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]