From: Ulf Jasper <ulf.jasper@web.de>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
56241@debbugs.gnu.org, hokomo <hokomo@airmail.cc>
Subject: bug#56241: [PATCH] icalendar doesn't correctly process arbitrary diary sexp entries
Date: Thu, 24 Nov 2022 19:07:12 +0100 [thread overview]
Message-ID: <87cz9ccjlb.fsf@panama> (raw)
In-Reply-To: <87o7sxpgfm.fsf@panama> (Ulf Jasper's message of "Wed, 23 Nov 2022 21:24:45 +0100")
Am 23.11.2022 um 21:24 (+0100) schrieb Ulf Jasper:
> I added a test to icalendar-tests.el that verifies that patch
> 0001-Fix-detecting-dotted-pairs.patch works as expected.
>
> I also prepared two additional tests for the other examples where
> icalendar-export fails. For the time being they are commented out as
> there is no fix available yet. Patch
> 0002-Draft-fix-nested-diary-sexps.patch seems to fix one of the examples
> but apparently breaks test 'icalendar-real-world'. So a look at
> 'icalendar--convert-sexp-to-ical' seems to be necessary.
There was a testcase in 'icalendar-real-world' that relied on
icalendar-export to fail on a particular sexp. With patch 0002... that
testcase behaves differently (i.e. export works correctly now). In
other words: breaking that test was correct.
Applied patch 0002... and updated icalendar-tests.
Best,
Ulf
next prev parent reply other threads:[~2022-11-24 18:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 18:36 bug#56241: [PATCH] icalendar doesn't correctly process arbitrary diary sexp entries hokomo
2022-06-27 8:04 ` Lars Ingebrigtsen
2022-06-27 9:42 ` hokomo
2022-06-28 11:21 ` Lars Ingebrigtsen
2022-07-06 18:58 ` hokomo
2022-07-07 8:08 ` Lars Ingebrigtsen
2022-07-24 18:14 ` Ulf Jasper
2022-11-11 13:38 ` Stefan Kangas
2022-11-23 20:24 ` Ulf Jasper
2022-11-24 18:07 ` Ulf Jasper [this message]
2023-07-04 10:29 ` Brendan O'Dea
2023-07-04 14:20 ` Mattias Engdegård
2023-07-07 13:15 ` Mattias Engdegård
2024-01-28 17:09 ` Jeremy Harrison via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz9ccjlb.fsf@panama \
--to=ulf.jasper@web.de \
--cc=56241@debbugs.gnu.org \
--cc=hokomo@airmail.cc \
--cc=larsi@gnus.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.